-
Notifications
You must be signed in to change notification settings - Fork 31
[@pika/plugin-ts-standard-pkg] Handle "incremental: true" #68
Comments
This is a great idea, but unfortunately right now we clear the
I'm leaning towards # 2, at least since this isn't the first time that has been asked for |
@FredKSchott I'm not sure what "watch mode" would be for personally, but if people are asking for it, then yea, making use of the performance gain of |
@FredKSchott So without knowing how any watch mode would work, the fix would either be to override the Obviously overriding the setting would be the better solution, like this (https://github.com/oBusk/builders/commit/2e4dbf49f9f9e7842003de6bd2395d7f050912ed), but the problem with that, is that there is no way to "unset" the
So the other option would be to add warning for it, so the user is aware why the build isn't working, would look something like this; https://github.com/oBusk/builders/commit/64b26dfcf8ab95c3ef28fef76069fce557a787ce |
There are problems when/if
incremental: true
in the usedtsconfig.json
..tsbuildinfo
is outputted intodist-src
tsBuildInfoFile
is set, incremental builds will fail withError: "dist-src/" does not exist, or was not yet created in the pipeline.
I don't know if there is any gain in trying to support
incremental: true
or if the plugin should justconsole.error()
or force the setting tofalse
.The text was updated successfully, but these errors were encountered: