Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.X Discussion #274

Closed
PrestonN opened this issue Jun 14, 2019 · 11 comments
Closed

Release 0.6.X Discussion #274

PrestonN opened this issue Jun 14, 2019 · 11 comments

Comments

@PrestonN
Copy link
Member

Hello everyone! Since we have a new release out that means that we have a new discussion thread. This release introduced some big changes. What do you think? Interested to hear your feedback.

No major question this time around. Enjoy!

@aproposnix
Copy link

aproposnix commented Jun 15, 2019

Hi there. Unfortunately issue #71 doesn't appear fixed for me. Though it has improved a little (it's not just a small window in the middle of my screen anymore), it's still not remembering that it's a maximized window.

EDIT: Also, it seems that the popular and trending playlists have been removed. Was this intentional?
Edit2: That's weird. This morning popular and trending were not in the sidebar... now they are. :/
Edit3: So it seems the issue with the trending and popular feeds missing is because of the "distraction free" mode. It would be nice to have distraction free mode but keep the playlists.

@ADepic
Copy link

ADepic commented Jun 15, 2019

I have quite a few issues:

  • Usually pressing right/left arrow keys moves the video 30 seconds forwards/backwards, other times it is 5 seconds. (It should consistently be 5 or 10 seconds; 30 seconds is too much)
  • When fullscreening, captions become huge.
  • When not fullscreen, two lines of captions overlap
  • Resolution does not change immediately, only buffering changes the resolution (requires you to scrub the video forward and then backwards again)
  • Sometimes infinite loading screen (need to go back to subscriptions/trending and then return to the video to make it work)
  • Save settings button very hidden, some might be under the illusion that the button doesn't exist because "Use Dark theme" applies immediately without "save settings"
  • Sometimes Dash formats doesn't work, reverts to legacy(but sometimes reverting from legacy to dash makes dash work!)
  • The range of the options button (3 dots) for a video (in subscriptions/trending etc.) is extremely small. Pressing only slightly to the left will actually play the video instead of showing options.
  • Probably lots more I haven't figured out in my 5 minutes of testing

@ghost
Copy link

ghost commented Jun 15, 2019

One thing that sometimes bugs me on 0.5.3 is as follows: Play something and remain on that screen. Do something else for a while, e.g. lock your screen while you are at work. When you come back you can't play the same video anymore, you have to navigate through it manually (for example: go back into favorites and open it again). I haven't figured out what exactly causes this.

@d43m0nhLInt3r
Copy link
Contributor

d43m0nhLInt3r commented Jun 15, 2019

Terminal output when I try to start freetube: [12225:0616/001414.261433:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /opt/FreeTube/chrome-sandbox is owned by root and has mode 4755. Trace/breakpoint trap

temporary workaround: freetube --no-sandbox

permanent workaround: cd /opt/FreeTube/ && sudo chmod 4755 chrome-sandbox

@86476451
Copy link

I really like the new Distraction free mode. By removing Trending and Most Popular, it should keep my IQ from dropping out of curiosity.
It does however disable related videos and comments, which sometimes come in handy. I hope it's possible to add a toggle for them individually, or one for both, doesn't matter.

Slightly off-topic but on your donations page there is space for other cryptocurrencies too. I would gladly donate if you listed a privacy coin.

@86476451
Copy link

One small issue.
While the initial buffering is running it is impossible to stop the video from eventually playing without clicking directly on the "play" button. Previously it was possible to quickly pause it and then let it sit for a while if one wanted to.

@ghost
Copy link

ghost commented Jun 17, 2019

Its showing great progress, however it appears that there is no "autoplay next" feature? If the video ends the next one doesnt start. I dont know if its a bug or not since I have autoplay enabled in settings.

@PrestonN
Copy link
Member Author

Thanks for the feedback everyone! Glad the new release has been going (mostly!) smooth. I'll try to address some of your comments.

Usually pressing right/left arrow keys moves the video 30 seconds forwards/backwards, other times it is 5 seconds. (It should consistently be 5 or 10 seconds; 30 seconds is too much

Answered over at #289.

When fullscreening, captions become huge.
When not fullscreen, two lines of captions overlap

I will address this in the next release. I haven't decided if it will for a patch release or if I will hold it off for a full release. It depends on my free time.

Resolution does not change immediately, only buffering changes the resolution (requires you to scrub the video forward and then backwards again)

I'll try to see if I can get this fixed eventually, but I don't see it happening soon. It's likely I just need to delve into the MediaElement code a little bit more to make it function this way.

Sometimes infinite loading screen (need to go back to subscriptions/trending and then return to the video to make it work)

I still haven't pinpointed the exact reason as to why it is behaving this way. I'll keep an eye out for any solutions though.

Save settings button very hidden, some might be under the illusion that the button doesn't exist because "Use Dark theme" applies immediately without "save settings"

I've noticed this after a couple of users have reached out to me. I've already posted screenshots in Matrix but there will be a redesign of the settings page which will make it a little more obvious that the settings need to be saved in order for your changes to take affect.

Sometimes Dash formats doesn't work, reverts to legacy(but sometimes reverting from legacy to dash makes dash work!)

There have been a couple of small issues with the dash formats where both myself and @omarroth haven't been able to completely figure out what's going on. Possible solutions would break Dash on Invidious or vice versa. We have a pretty good solution right now that seems to work out most of the time, but we'll try to tackle this again when we can.

The range of the options button (3 dots) for a video (in subscriptions/trending etc.) is extremely small. Pressing only slightly to the left will actually play the video instead of showing options.

I'll try to extend the click range on this.

One thing that sometimes bugs me on 0.5.3 is as follows: Play something and remain on that screen. Do something else for a while, e.g. lock your screen while you are at work. When you come back you can't play the same video anymore, you have to navigate through it manually (for example: go back into favorites and open it again). I haven't figured out what exactly causes this.

There's nothing I can do about that, and it's because of how YouTube works.

Video URLs from YouTube will expire after a set amount of time, typically around 6 hours depending on the video. We have to grab a new URL after that set amount of time in order to play the video again.

Terminal output when I try to start freetube: [12225:0616/001414.261433:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /opt/FreeTube/chrome-sandbox is owned by root and has mode 4755. Trace/breakpoint trap

I believe the issue here has to do with the version of electron-builder I was using. This should be fixed in the latest version and I'll include the fix in the next release.

It does however disable related videos and comments, which sometimes come in handy. I hope it's possible to add a toggle for them individually, or one for both, doesn't matter.

I'll likely add support to hide everything separately at some point in the future. It's a lot more work compared to the current implementation so it will take time before I can offer that. No ETA on it just yet but I guess it will depend on user demand on how important they think this is.

Slightly off-topic but on your donations page there is space for other cryptocurrencies too. I would gladly donate if you listed a privacy coin.

I've purposely stayed light on the amount of Cryptocurrencies that I support because I didn't know what others would want me to use. I'll likely add more as people request them so I'm more than happy to add more methods. Monero is typically the most popular privacy coin so I will get a wallet setup for donations at some point.

One small issue.
While the initial buffering is running it is impossible to stop the video from eventually playing without clicking directly on the "play" button. Previously it was possible to quickly pause it and then let it sit for a while if one wanted to.

Is "AutoPlay" turned off in your settings? That might be the problem.

Its showing great progress, however it appears that there is no "autoplay next" feature? If the video ends the next one doesnt start. I dont know if its a bug or not since I have autoplay enabled in settings.

Answered in #283

@d43m0nhLInt3r
Copy link
Contributor

When i copy a link in the video description with an "@" inside and i paste it it comes out as an "%40".
Example: https://beta.lbry.tv/@TheLinuxGamer --> https://beta.lbry.tv/%40TheLinuxGamer

@gkeegan
Copy link

gkeegan commented Jul 22, 2019

That's normal behavior, and will go to the same link. Seems like an easier fix though.

@PrestonN
Copy link
Member Author

Closing this issue as a new major release is now available and a new discussion thread has been made.

@PrestonN PrestonN unpinned this issue Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants