Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sponsor segments loaded, even if skipped #2860

Closed
5 tasks done
UltraBlackLinux opened this issue Nov 13, 2022 · 9 comments
Closed
5 tasks done

[Bug]: Sponsor segments loaded, even if skipped #2860

UltraBlackLinux opened this issue Nov 13, 2022 · 9 comments
Labels
B: content not loading B: Unofficial Download bug Something isn't working wontfix This will not be worked on

Comments

@UltraBlackLinux
Copy link

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

Freetube loads the sponsor segment, even if it's going to be skipped leading to a playback stop until the part after the segment is loaded once freetube skips it

Expected Behavior

it should not load the sponsor segment and start immediately loading the part behind it

Issue Labels

content not loading

FreeTube Version

v0.18.0 Beta

Operating System Version

Linux lolcat 6.0.8-zen1-1-zen #1 ZEN SMP PREEMPT_DYNAMIC Thu, 10 Nov 2022 21:14:22 +0000 x86_64 GNU/Linux

Installation Method

AUR

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@efb4f5ff-1298-471a-8973-3d47447115dc

Hi @UltraBlackLinux do u experience this behavior on all videos?

@UltraBlackLinux
Copy link
Author

yeah I do. It's very easy to reproduce.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@efb4f5ff-1298-471a-8973-3d47447115dc

Closing, because this requires us to dig into video.js internals and tell it to not download the parts that sponsorblock has marked as sponsors. This is only really noticeable when YouTube is throttling us

It's basically out of our control unless we want to rewrite parts of video.js

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the wontfix This will not be worked on label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: content not loading B: Unofficial Download bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants