-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Sponsor segments loaded, even if skipped #2860
Labels
B: content not loading
B: Unofficial Download
bug
Something isn't working
wontfix
This will not be worked on
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @UltraBlackLinux do u experience this behavior on all videos? |
yeah I do. It's very easy to reproduce. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Closing, because this requires us to dig into video.js internals and tell it to not download the parts that sponsorblock has marked as sponsors. This is only really noticeable when YouTube is throttling us It's basically out of our control unless we want to rewrite parts of video.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B: content not loading
B: Unofficial Download
bug
Something isn't working
wontfix
This will not be worked on
Guidelines
Describe the bug
Freetube loads the sponsor segment, even if it's going to be skipped leading to a playback stop until the part after the segment is loaded once freetube skips it
Expected Behavior
it should not load the sponsor segment and start immediately loading the part behind it
Issue Labels
content not loading
FreeTube Version
v0.18.0 Beta
Operating System Version
Linux lolcat 6.0.8-zen1-1-zen #1 ZEN SMP PREEMPT_DYNAMIC Thu, 10 Nov 2022 21:14:22 +0000 x86_64 GNU/Linux
Installation Method
AUR
Primary API used
Local API
Last Known Working FreeTube Version (If Any)
No response
Additional Information
No response
Nightly Build
The text was updated successfully, but these errors were encountered: