Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dearrow titles with "force keep capitalization" markers are not cleaned #4524

Closed
5 of 6 tasks
Nemo157 opened this issue Jan 6, 2024 · 0 comments · Fixed by #4569
Closed
5 of 6 tasks

[Bug]: Dearrow titles with "force keep capitalization" markers are not cleaned #4524

Nemo157 opened this issue Jan 6, 2024 · 0 comments · Fixed by #4569
Labels

Comments

@Nemo157
Copy link

Nemo157 commented Jan 6, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

Dearrow appears to be adding some inline markup to the video titles, indicating whether some capitals should be kept even when applying things like titlecase modifiers to the custom title. This can be seen on the video Uuh_T648J_8 for example:

image

> curl -sS https://sponsor.ajay.app/api/branding/74db | jq -r '.["Uuh_T648J_8"].titles[].title'
Building >Tally >Ho's standing rig | >Rebuilding >Tally >Ho >E176
Building >Tally >Ho's rig | >Rebuilding >Tally >Ho >E176

As far as I can tell, the exact format of this markup isn't documented anywhere. I inspected the browser extension source to confirm it is parsing it, but the logic is quite convoluted so I haven't fully worked out what it's doing with it.

(sponsorblock mention for searchability)

Expected Behavior

Dearrowed video titles are rendered without the markup.

Issue Labels

usability issue

FreeTube Version

v0.19.1 beta

Operating System Version

Linux 6.6.3 #1-NixOS SMP PREEMPT_DYNAMIC Tue Nov 28 17:20:18 UTC 2023 x86_64 GNU/Linux

Installation Method

Nix (Unofficial)

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant