-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Add Everforest themes and variants #4650
Comments
Everforest feels more in line with similar color themes with roots in terminal emulator customization (Dracula, Catpuccin, even Nordic since it's based on Nord). At some point, it feels like this project is going to have to define theming limits and goals, or, provide some more flexible theming options for all of us our several favorite themes 😄 (I'd be up for helping strategize and design the UI for the latter.) |
Just wanted to let you know, I am working on this. |
I noticed that there are 3 variants for both the light and dark theme: Soft, Medium, Hard. Will you implement all 6 or pick one per theme? |
Related to the earlier discussion being had on this issue, I think someone should create a story for proposing / brainstorming a better system for managing the large number of themes we have. A separate dark mode toggle, a sub-variant dropdown or nested dropdown, something like that. Even 3 is a lot when we're already at 15 or so. |
I implemented all of them. |
Some ideas are in #5932. I created this issue a while back. |
I'm particularly talking about the size of the base themes dropdown, which isn't covered in that story. |
Oh, sorry. I did not read that correctly. |
Guidelines
Problem Description
I'd like to add the Everforest theme to FreeTube's themes.
Proposed Solution
My proposed solution would be to add the Everforest variants to Freetube's theme file. There are six Everforest variants in all; three contrast variants (soft, medium/default, hard) on one axis and two mode variants (light mode, dark mode) on another axis.
I intend to add all variants to the theme list but I can just add the two medium variants if there is pushback. (I note here that some other color schemes have a lot of variants in the theme list, though!)
I am also volunteering to take on the work and submit the pull request when completed.
Alternatives Considered
There are a lot of color themes out there and a lot of generous contributors who may want to add plenty of them to FreeTube. At some point we may want to consider another way to add themes in the UI, or a custom theme CSS option accessible for users.
Issue Labels
new feature, new optional setting, visual improvement
Additional Information
No response
The text was updated successfully, but these errors were encountered: