Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add Everforest themes and variants #4650

Open
3 tasks done
cozy-isaac opened this issue Feb 7, 2024 · 9 comments · May be fixed by #6468
Open
3 tasks done

[Feature Request]: Add Everforest themes and variants #4650

cozy-isaac opened this issue Feb 7, 2024 · 9 comments · May be fixed by #6468

Comments

@cozy-isaac
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

I'd like to add the Everforest theme to FreeTube's themes.

Proposed Solution

My proposed solution would be to add the Everforest variants to Freetube's theme file. There are six Everforest variants in all; three contrast variants (soft, medium/default, hard) on one axis and two mode variants (light mode, dark mode) on another axis.

I intend to add all variants to the theme list but I can just add the two medium variants if there is pushback. (I note here that some other color schemes have a lot of variants in the theme list, though!)

I am also volunteering to take on the work and submit the pull request when completed.

Alternatives Considered

There are a lot of color themes out there and a lot of generous contributors who may want to add plenty of them to FreeTube. At some point we may want to consider another way to add themes in the UI, or a custom theme CSS option accessible for users.

Issue Labels

new feature, new optional setting, visual improvement

Additional Information

No response

@bungadrum
Copy link

I already requested the Otis theme it's similar to the Everforest one

2
3

@cozy-isaac
Copy link
Author

cozy-isaac commented Feb 7, 2024

Everforest feels more in line with similar color themes with roots in terminal emulator customization (Dracula, Catpuccin, even Nordic since it's based on Nord). At some point, it feels like this project is going to have to define theming limits and goals, or, provide some more flexible theming options for all of us our several favorite themes 😄 (I'd be up for helping strategize and design the UI for the latter.)

@DontBlameMe99
Copy link
Contributor

Just wanted to let you know, I am working on this.

@efb4f5ff-1298-471a-8973-3d47447115dc

I noticed that there are 3 variants for both the light and dark theme: Soft, Medium, Hard. Will you implement all 6 or pick one per theme?

@kommunarr
Copy link
Collaborator

Related to the earlier discussion being had on this issue, I think someone should create a story for proposing / brainstorming a better system for managing the large number of themes we have. A separate dark mode toggle, a sub-variant dropdown or nested dropdown, something like that. Even 3 is a lot when we're already at 15 or so.

@DontBlameMe99
Copy link
Contributor

I noticed that there are 3 variants for both the light and dark theme: Soft, Medium, Hard. Will you implement all 6 or pick one per theme?

I implemented all of them.

@DontBlameMe99
Copy link
Contributor

Related to the earlier discussion being had on this issue, I think someone should create a story for proposing / brainstorming a better system for managing the large number of themes we have. A separate dark mode toggle, a sub-variant dropdown or nested dropdown, something like that. Even 3 is a lot when we're already at 15 or so.

Some ideas are in #5932. I created this issue a while back.

@kommunarr
Copy link
Collaborator

I'm particularly talking about the size of the base themes dropdown, which isn't covered in that story.

@DontBlameMe99
Copy link
Contributor

I'm particularly talking about the size of the base themes dropdown, which isn't covered in that story.

Oh, sorry. I did not read that correctly.

@DontBlameMe99 DontBlameMe99 linked a pull request Dec 28, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
Development

Successfully merging a pull request may close this issue.

5 participants