Error: You have an error in your SQL syntax;

[linawolf]

Describe the bug
On doing database compare after creating my block I get the following error:

To Reproduce

name: t3docs/carousel
typeName: t3docs_carousel
group: default
prefixFields: true
prefixType: full
fields:
  - identifier: carousel-items
    type: Collection
    foreign_field: parentid
    fields:
      - identifier: header
        type: Text
      - identifier: description
        type: Textarea
        enableRichtext: true
      - identifier: image
        type: File

Expected behavior
If the special sign - is not possible it should be forbidden or transformed.

TYPO3 Version
13.4.1

Content Blocks Version:
friendsoftypo3/content-blocks (1.0.4)

Additional context
Using identifier: carousel_items works

[nhovratov]

Related: #30

[nhovratov]

@linawolf This works for me. I have ddev with MariaDB 10.3.

It's not forbidden to have dashes. MySql supports it. But in some cases they are not escaped. This is probably an issue in Core. Not sure if this is related to certain DBs / version.

[linawolf]

Using
mariadb_version: "10.5", php_version: "8.2"
In ddev this causes an error for me

[nhovratov]

See, for me it is escaped:

I'll check 10.5

[nhovratov]

I don't know, this would be an arbitrary decision. Better fix Core to properly escape them. We should just only document underscore and state this is best practice.

Just checked with Maria 10.5, works for me.

[linawolf]

Would it be hard to sanitize the input? There could be other special signs causing trouble or worse as well?

[nhovratov]

Needs to be discussed with some Core developers. I have no idea what characters are allowed / not allowed cross-db. I don't see it being the responsibility of this extension right now. In the end, this is just converted to TCA. And if you define a TCA column with dashes, this would be exactly the same.