-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show-smartparens-mode not working when cursor on right parenthesis #758
Comments
Try to set The problem is that vim and emacs handle the point differently. In vim cursor is on the character while in emacs cursor is between characters, so even if it actually draws on top it is in reality between that and the previous char. We only highlight the pair backwards if the closing delimiter is the previous character. |
Thanks for clarifying. I still observed the same behavior after setting |
It seems that setting |
Same issue here - to clarify, this is only an issue in normal mode, works fine in insert mode. @Fuco1 would it be possible to add a |
We have that already (and (or (sp--evil-normal-state-p)
(sp--evil-motion-state-p)
(sp--evil-visual-state-p))
(sp--looking-at (sp--get-allowed-regexp))) There's probably some other issue /shrug |
I have tried this just now with the latest evil from melpa, latest smartparens on emacs 25.2.1 and I can not reproduce the problem. I have the exact same text as on the screenshot and it highlights as expected Can you try this without spacemacs, just with evil mode and smartparens loaded? /cc @agzam |
Should be fixed in master. |
Thanks! |
Expected behavior
Left matching parenthesis should be highlighted when the cursor is on the right parenthesis.
Actual behavior
Left parenthesis is not highlighted, see the fig below:
Note that when the cursor is on the left parenthesis, the highlighting works as expected:
Steps to reproduce the problem
Just open any elisp buffer and move the cursor as described above. Make sure the built-in
show-paren-mode
is off.Edit: I'm using evil-mode, above repro guide is for the 'normal' state. For emacs state, to reproduce, you should move the cursor to the point before the right parenthesis.
Environment & version information
smartparens
version: smartparens-20170618.744M-x emacs-version
): GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.10) of 2017-04-22The text was updated successfully, but these errors were encountered: