Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Limiter abstraction for Executor parameters #2234

Closed
acerone85 opened this issue Sep 20, 2024 · 1 comment
Closed

Introduce Limiter abstraction for Executor parameters #2234

acerone85 opened this issue Sep 20, 2024 · 1 comment

Comments

@acerone85
Copy link
Contributor

          Maybe we can take this opportunity and rename this to `transaction_count_limit`. 

I know it was merged like that in this PR, but this one will soon bring yet another similar name. Having such generic name as transactions_limit could be confusing.

Also, we might consider introducing a "limiter" abstraction in a follow-up ticket, instead of having three separate params.

Originally posted by @rafal-ch in #2189 (comment)

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 17, 2024

We still need separate parameters for WASM interface, so I think we don't need to change it=)

@xgreenx xgreenx closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants