Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically insert overlay in to webpack entry property #4

Open
G-Rath opened this issue Jun 29, 2018 · 3 comments
Open

Automatically insert overlay in to webpack entry property #4

G-Rath opened this issue Jun 29, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@G-Rath
Copy link
Owner

G-Rath commented Jun 29, 2018

As @shellscape mentioned in this issue; webpack-hot-client does automatic entry injection.

It would be nice if this package did the same, so that users wouldn't have to add the entry manually to their webpack configurations.

@G-Rath G-Rath added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Jun 29, 2018
@G-Rath
Copy link
Owner Author

G-Rath commented Jun 29, 2018

I've had a brief glance already, and looking at it from someone outside the webpack development community, it seems like a pretty complex bit of code.

I'd greatly welcome any input from the surrounding community for this one (and on #1).

@shellscape
Copy link

Yeah it's not an easy bit of code. Not because it's overly complex, but because there's been a lot of trouble around how automatic injection should be done, due to the many different wants that entries can be setup in configs.

We might have to look into a way to create "plugin" client scripts for webpack-hot-client and have extension scripts bundled with the main hot-client client script.

@G-Rath
Copy link
Owner Author

G-Rath commented Jul 1, 2018

In light of the solution for #5, I don't think this feature is 'needed' anymore, at least for now.

I'm still interested in investigating the works behind AEI, but think that importing the overlay into the bundle is ultimately the better solution, as it sidesteps all the problems associated with AEI.

I'm going to keep this issue open for now, but will likely close it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants