Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws error when there is no hot client running #8

Open
agilgur5 opened this issue Aug 10, 2018 · 0 comments
Open

Throws error when there is no hot client running #8

agilgur5 opened this issue Aug 10, 2018 · 0 comments

Comments

@agilgur5
Copy link

agilgur5 commented Aug 10, 2018

The specific error is:

Uncaught ReferenceError: __hotClientOptions__ is not defined

The error points to line 125, which assumes __hotClientOptions__ exists in the global scope.

Filed this issue at @G-Rath 's request from #5 (comment) . Due to this error, webpack-serve-overlay cannot run on all environments as it implicitly requires a hot client to exist and will error out the bundle otherwise.

Screenie of browser console just in case:
screen shot 2018-08-09 at 10 49 17 pm

If needed, you can find a reproducible (but not minimal) case in my boilerplate files here by running npm run build:watch and opening index.html.

Didn't file a PR instead since I'm not sure how you'd want to handle this (there are many options).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant