Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] - Option to scale geometry #228

Open
alexvalentine94 opened this issue Jun 14, 2024 · 2 comments
Open

[Feature request] - Option to scale geometry #228

alexvalentine94 opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@alexvalentine94
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Often we encounter issues related to coincident surfaces in MCNP when using universes.

Describe the solution you'd like

One way around this is to nudge or scale the geometry by a very small amount to avoid coincident surfaces. This would be a nice feature option in GEOUNED.

Describe alternatives you've considered

Additional context

@alexvalentine94 alexvalentine94 added the enhancement New feature or request label Jun 14, 2024
@alexvalentine94
Copy link
Collaborator Author

As discussed with @psauvan, default in the code currently is factor 10 for mm - cm. User input option can be added to allow flow specification of scaling factor which defaults to 1.

@psauvan
Copy link
Member

psauvan commented Jun 15, 2024

Scaling is performed when surface parameters are written in the output file.
The function below writes the surface parameters to MCNP output file.

def mcnp_surface(id, Type, surf, options, tolerances, numeric_format):

In this function (and corresponding functions writing other output formats), the way the factor is applied is not consistent between the diferent surface type. Sometimes the parameter value is scaled,

        Pos = surf.Center * 0.1
        rad = surf.Radius * 0.1

sometimes only the scaled value in written in the output file.

                mcnp_def = "{:<6d} PX  {:{x}}".format(id, D / 10.0, x=numeric_format.P_xyz)

When the additional scaling factor is implemented, a homogenezation of the the way the parameters are scaled should be carried out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants