Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for setting custom thresholds #21

Closed
1 task
matthiasschaub opened this issue May 18, 2021 · 2 comments
Closed
1 task

Add functionality for setting custom thresholds #21

matthiasschaub opened this issue May 18, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request indicator priority:high Should be addressed as soon as possible (next release)

Comments

@matthiasschaub
Copy link
Collaborator

matthiasschaub commented May 18, 2021

Thresholds are used during the computation of indicators to decide the quality of the result. This can be simple values or more sophisticated functions. Those are currently defined either in the indicator.py or in the metadata.yaml file for each indicator.

It makes sense to set different thresholds for multiple instances of an indicators (e.g. same indicator for different layer or regions).

Implement custom thresholds:

  • GHSPOP Indicators

Ideally allow to define parameters in threshold function.

@matthiasschaub matthiasschaub added the enhancement New feature or request label May 18, 2021
@matthiasschaub matthiasschaub self-assigned this May 18, 2021
@matthiasschaub
Copy link
Collaborator Author

matthiasschaub commented May 25, 2021

Should there be a default threshold? Should this be definied at the indicator level or on the layer level or indicator+layer combination level?

@matthiasschaub matthiasschaub added the priority:high Should be addressed as soon as possible (next release) label May 25, 2021
@matthiasschaub matthiasschaub added this to the Release 0.5.0 milestone Jun 7, 2021
@matthiasschaub matthiasschaub removed the priority:high Should be addressed as soon as possible (next release) label Sep 6, 2021
@matthiasschaub matthiasschaub removed this from the Release 0.6.0 milestone Sep 6, 2021
@matthiasschaub
Copy link
Collaborator Author

Closing this for now.

Thresholds for each indicator are often implemented has function. Therefor to change the threshold one needs to understand implementation details of the indicator. This is not very user friendly.

A workaround is to request the indicator using the OQT API and then using the provided data to reclassify with a custom threshold.

@matthiasschaub matthiasschaub added priority:high Should be addressed as soon as possible (next release) indicator labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request indicator priority:high Should be addressed as soon as possible (next release)
Projects
None yet
Development

No branches or pull requests

1 participant