Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acetic acid simulation problem #19

Closed
jpotoff opened this issue Jun 30, 2016 · 9 comments
Closed

Acetic acid simulation problem #19

jpotoff opened this issue Jun 30, 2016 · 9 comments

Comments

@jpotoff
Copy link
Collaborator

jpotoff commented Jun 30, 2016

GCMC simulations of acetic acid produce zero accepted molecule swap moves. Running version 1.7.

@msoroush
Copy link
Collaborator

Would you please attache your acetic acid simulation files (*.pdb, *.psf, parameter and input file)?

@jpotoff
Copy link
Collaborator Author

jpotoff commented Jun 30, 2016

PSF, PDB, parameter and in.dat files attached.

input_files.zip

@msoroush
Copy link
Collaborator

msoroush commented Jul 1, 2016

Looking at *.psf files I noticed that the net charge is not zero, it is +0.12. That might be the issue. Would you please fix the psf file and try to run your simulation again?

@jpotoff
Copy link
Collaborator Author

jpotoff commented Jul 1, 2016

Good catch on the PSF file. Rebuilt it correctly and the problem remains.

BTW, we need to add error checking to the code to flag molecules that have a net charge that is not equal to zero.

@LSchwiebert
Copy link
Collaborator

We should add a check in the code that loads the psf file to make sure that the net charge is zero. If it is not zero, we should generate an error or warning message as appropriate, while allowing for some tolerance. For instance, a charge greater +/- 1x10^-7 should generate a warning or error message.

@LSchwiebert
Copy link
Collaborator

Can you please upload the corrected input files that still exhibit the problem?

@jpotoff
Copy link
Collaborator Author

jpotoff commented Jul 2, 2016

Revised PSF files are attached. Parameter, topology and in.dat files are also included.
input_files2.zip

@msoroush
Copy link
Collaborator

msoroush commented Aug 8, 2016

There was an issue with calculating correction term of electrostatic for branch molecules. The fix has been committed to master, ewald, openMP and openMP-cache-noncache branches. Would you please download the new code and try to run your simulation?

@YounesN
Copy link
Collaborator

YounesN commented Sep 7, 2016

The bug is fixed and pushed as Version 1.71.

@YounesN YounesN closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants