-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acetic acid simulation problem #19
Comments
Would you please attache your acetic acid simulation files (*.pdb, *.psf, parameter and input file)? |
PSF, PDB, parameter and in.dat files attached. |
Looking at *.psf files I noticed that the net charge is not zero, it is +0.12. That might be the issue. Would you please fix the psf file and try to run your simulation again? |
Good catch on the PSF file. Rebuilt it correctly and the problem remains. BTW, we need to add error checking to the code to flag molecules that have a net charge that is not equal to zero. |
We should add a check in the code that loads the psf file to make sure that the net charge is zero. If it is not zero, we should generate an error or warning message as appropriate, while allowing for some tolerance. For instance, a charge greater +/- 1x10^-7 should generate a warning or error message. |
Can you please upload the corrected input files that still exhibit the problem? |
Revised PSF files are attached. Parameter, topology and in.dat files are also included. |
There was an issue with calculating correction term of electrostatic for branch molecules. The fix has been committed to master, ewald, openMP and openMP-cache-noncache branches. Would you please download the new code and try to run your simulation? |
The bug is fixed and pushed as Version 1.71. |
GCMC simulations of acetic acid produce zero accepted molecule swap moves. Running version 1.7.
The text was updated successfully, but these errors were encountered: