Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Is RateControlPreanalysisEnable for AVC still an integer value? Documentation #497

Closed
lextra2 opened this issue Sep 2, 2024 · 2 comments
Labels

Comments

@lextra2
Copy link

lextra2 commented Sep 2, 2024

See

#define AMF_VIDEO_ENCODER_PREENCODE_ENABLE L"RateControlPreanalysisEnable" // amf_int64(AMF_VIDEO_ENCODER_PREENCODE_MODE_ENUM); default = AMF_VIDEO_ENCODER_PREENCODE_DISABLED; enables pre-encode assisted rate control

But for HEVC & AV1 its a bool:

#define AMF_VIDEO_ENCODER_HEVC_PREENCODE_ENABLE L"HevcRateControlPreAnalysisEnable" // bool; default = depends on USAGE; enables pre-encode assisted rate control

Is this still the case or is this an oversight?

@MikhailAMD
Copy link
Collaborator

It was an oversight in H264 and supposed to be bool. But it is too late to change for backward compatibility reasons.

@lextra2
Copy link
Author

lextra2 commented Sep 2, 2024

Thank you for clarifying!

@lextra2 lextra2 closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants