Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E improve: workbook_loader() #2675

Closed
Tracked by #2672
jadudm opened this issue Nov 1, 2023 · 0 comments · Fixed by #2944
Closed
Tracked by #2672

E2E improve: workbook_loader() #2675

jadudm opened this issue Nov 1, 2023 · 0 comments · Fixed by #2944
Assignees
Labels

Comments

@jadudm
Copy link
Contributor

jadudm commented Nov 1, 2023

workbook_loader()

This is where exceptions will land.

That is, if there is an exception thrown (e.g. DataMigrationError or similar), this is a critical point where it should be caught, and then logged so we can come back to it.

This may be true for the general info as well (line 54).

In either case, this code has no mechanisms for catching exceptions thrown and then logging the relevant information regarding that error. We need to do so, and it is probably somewhere around here.

@phildominguez-gsa phildominguez-gsa changed the title E2E improve: L75 - workbook loader E2E improve: workbook_loader() Nov 8, 2023
@sambodeme sambodeme added the eng label Nov 20, 2023
@github-project-automation github-project-automation bot moved this to Triage in FAC Nov 20, 2023
@danswick danswick moved this from Triage to Backlog in FAC Nov 30, 2023
@phildominguez-gsa phildominguez-gsa self-assigned this Dec 6, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in FAC Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
3 participants