Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog Facets Broken on Mobile #4543

Open
4 tasks
btylerburton opened this issue Nov 30, 2023 · 1 comment
Open
4 tasks

Catalog Facets Broken on Mobile #4543

btylerburton opened this issue Nov 30, 2023 · 1 comment
Labels
bug Software defect or bug

Comments

@btylerburton
Copy link
Contributor

Dataset filtering on mobile is broken and/or confusing. To ensure a satisfactory experience while using the catalog on mobile devices, fixes need to be made to catalog search UI.

Vanilla CKAN demo does not have this problem. We should back out our customizations in datagovtheme until we can reproduce the same results as vanilla CKAN.

Data.gov Catalog

Screenshot 2023-11-30 at 11 10 42 AM Screenshot 2023-11-30 at 11 10 48 AM

Demo CKAN (src)

Screenshot 2023-11-30 at 11 10 32 AM Screenshot 2023-11-30 at 11 10 28 AM

How to reproduce

  1. Visit catalog.data.gov/dataset on a mobile device
  2. Observe that the facets are displayed on page load, instead of being hidden.
  3. Click the "Filter Results" button
  4. Observe that a modal close "X" button is rendered, with no content, and that the page is locked until that button is clicked once again to remove it.

Expected behavior

  1. Facets should be hidden on mobile
  2. Clicking filter results should open a modal which displays the hidden facets.

Actual behavior

  1. Facets are displayed by default
  2. Clicking filter results button opens a non-existent model

Sketch

  • Remove whatever template in datagovtheme is overriding vanilla CKAN behavior.
  • Ensure:
    • Facets are hidden by default on mobile
    • Clicking the Filter Results button brings up a modal with all facets that are clickable
    • Search query box is not custom but mirrors the UI of appearance of vanilla CKAN
@btylerburton btylerburton added the bug Software defect or bug label Nov 30, 2023
@gujral-rei gujral-rei moved this to 📔 Product Backlog in data.gov team board Nov 30, 2023
@nickumia
Copy link

nickumia commented Dec 7, 2023

Look at that sketch! Easy 😉

@hkdctol hkdctol moved this from 📔 Product Backlog to 🧊 Icebox in data.gov team board Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software defect or bug
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

2 participants