Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade USMetadata at inventory app #1424

Closed
10 tasks
avdata99 opened this issue Feb 29, 2020 · 6 comments
Closed
10 tasks

Upgrade USMetadata at inventory app #1424

avdata99 opened this issue Feb 29, 2020 · 6 comments
Assignees

Comments

@avdata99
Copy link
Contributor

avdata99 commented Feb 29, 2020

Description

In the inventory-app we are using a fork of an abandoned repo.

As a part of a plan to upgrade CKAN extensions in use, and in order to improve the way that we manage forks we need to analyze if an upgrade here is needed.

Acceptance Criteria

  • This extension includes the best updates for other forks.
  • There's an issue requesting versioning.
  • We have a test environment for test this updated extension

Tasks

  • Analyze Adam's changes and define if we should use them.
  • Analyze Ljupka's changes and define if we should use them.
  • Fix errors at CI
  • Create a test environment with the inventory-app
  • Improve tests in this extension
  • Measure the effort to move the inventory-app to a new official version.
  • Write an issue to start versioning (e are in 0.2.1 from 7 years)

Analysis & notes

Our repo has test and CI but are failing.
We can consider our fork as the upstream version but some forks continue working here:

Note: Adam starts working from Ljupka repo. Maybe that repo was considered upstream at that time.
See the network graph:

Recommendation

Analyze the changes in this forks and upgrade our version if needed.

@adborden
Copy link
Contributor

Seems there is some confusion here. We've unassigned @pjsharpe07 who is not working on this. He was focused on only making sure USMetadata was working on the inventory CKAN 2.8 fork. I'm going to move this back to the sprint backlog and someone from ckan-multi team should pick this up.

@starsinmypockets
Copy link
Contributor

@adborden Looks like in terms of forks there is very little to do here until we are upgrading to 2.8

Complete analysis here:
https://gist.github.com/starsinmypockets/306f372141e95a3d8325bdd43a041be5

@adborden
Copy link
Contributor

@starsinmypockets 2.8 is in progress here https://github.com/GSA/inventory-app/tree/inventory_ckan_2.8, is there something else you need in order to continue this work?

@starsinmypockets
Copy link
Contributor

@adborden should I continue the work against 2.8 in progress?

@adborden
Copy link
Contributor

Yes, why don't you pull in @avdata99 as a pair.

One thing I want to call out: the Inventory 2.8 branch is using the datopian fork, so whatever fixes are necessary for USMetadata should be made so that we can switch back to using the GSA version.

@nickumia-reisys
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants