Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade datajson ext in catalog and inventory app #1429

Closed
14 tasks
avdata99 opened this issue Mar 3, 2020 · 1 comment
Closed
14 tasks

Upgrade datajson ext in catalog and inventory app #1429

avdata99 opened this issue Mar 3, 2020 · 1 comment
Assignees

Comments

@avdata99
Copy link
Contributor

avdata99 commented Mar 3, 2020

Description

In catalog and inventory apps we are using a fork of the Data.json extension. We use branch master in inventory and datagov in the catalog app.

As a part of a plan to upgrade CKAN extensions in use, and in order to improve the way that we manage forks we need to upgrade this extension.

Acceptance Criteria

  • We have an upstream version defined
  • If we define to use Datopian version
    • When there's a new release upstream, we can get onto it in under an hour
    • When there's a new release upstream, we see a notification in a Slack channel
  • We have tagged versions and clear policy about it
  • We have tests for this extension running in CI

Tasks

  • Define if GSA wants to continue its own repo as upstream.
  • If we define to use Datopian version
    • Create a test environment with the catalog-app
    • Test this extension
    • Measure the effort to move the catalog-app to this official archiver version.
  • If we use GSA version
    • Measure the effort to merge branches to use the same version in both apps.
  • We have tagged versions. We must define a clear policy for this and create a changelog file to clarify.

Analysis & notes

There is no version that can be considered upstream. Datopian also has a version based on a previous forks analysis. Datopian added some functionality to allow different schemas.

Both repos have tests and CI (datopian and GSA).

GSA's fork is Ahead in 22 commits and behind 171 commits.

Both repos have modifications in pasts weeks.
Some differences:

  • GSA version includes a Docker container and tests with docker
  • Datopian version includes the ability to work with different schemas. This could allow the same branch to be used for both applications (the Inventory app requires USMetadata which uses a different schema for datasets).

None of them is in active development

Recommendation

Define an upstream version who can be used in Catalog and Inventory apps. If we need to use USMetadata extension while harvesting at the Inventory app then Datopian version could be a good upstream.

@avdata99 avdata99 changed the title Upgrade datajson ext Upgrade datajson ext in catalog and inventory app Mar 3, 2020
@kimwdavidson kimwdavidson added this to the Data.gov Sprint 18 milestone Mar 23, 2020
@kimwdavidson
Copy link

Closing. Taking new approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants