Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Add to Calendar for Past events #921

Open
1 task done
smudra opened this issue Sep 26, 2024 · 2 comments
Open
1 task done

Remove Add to Calendar for Past events #921

smudra opened this issue Sep 26, 2024 · 2 comments
Labels

Comments

@smudra
Copy link

smudra commented Sep 26, 2024

Describe the bug

Here's a feedback I got from a QA friend who tested a past event.
https://jam.dev/c/742551f4-f73c-4ce8-8dd0-d10cb5c7fd6e

Steps to Reproduce

  1. Go to any expired event
  2. Example: https://playground.wordpress.net/scope:0.5855729227645725/event/gatherpress-huddle-41/
  3. See the Add to Calendar for a past event. This need not be there.

Screenshots, screen recording, code snippet

Screenshot 2024-09-26 at 3 10 48 PM

Environment information

MacBoook, Chrome, Firefox

WordPress information

Latest version.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@smudra smudra added the bug Something isn't working label Sep 26, 2024
@carstingaxion
Copy link
Collaborator

Hello @smudra ,

thanks for writing this down!

I had a similar thought some weeks in the past, wanted to disable the rendering of that block for past events and than realised … that there might be reasons to have this in place also for past events. So I stopped there.

Now it would be interesting to know, what you suggest. Should the block just be removed (or better: not rendered on the front end) for all past events? Should this be selectable? Is this kind of differentiation maybe interesting for other blocks, too?

Would appreciate your thoughts!

@smudra
Copy link
Author

smudra commented Sep 27, 2024

Hi @carstingaxion ,
I looked at the use case scenario for keeping the Add to Calendar on past events.

This is one of the things I found on ChatGPT:
_Users may want to associate notes, documents, or reminders with past events, like a meeting or conference. By adding the event to the calendar, they can append relevant information or materials to help recall specific details when needed.

Adding past events can help ensure that there are no gaps in their calendar, especially when reviewing activities over the year or for tax and legal purposes._

Maybe we can keep it for now :)
Thank you

@carstingaxion carstingaxion removed the bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants