Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce “wporg-replace” action to update version numbers #924

Open
1 task done
carstingaxion opened this issue Sep 26, 2024 · 7 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@carstingaxion
Copy link
Collaborator

carstingaxion commented Sep 26, 2024

Is your enhancement related to a problem? Please describe.

Currently the important version numbers are updated and changed by a custom cli script.

@mauteri and I want to test if it could be more reliable to use an established workflow by, @sc0ttkclark, a well-known member of the WordPress community.

https://github.com/sc0ttkclark/wporg-replace

Designs

It needs to be tested if this workflow could handle all of GatherPress’ needs:

.
├── .github
│   └── workflows
│       ├── coding-standards.yml
│       ├── phpunit-tests.yml
│       ├── sonarcloud.yml
│       └── wporg-replace.yml (The workflow needs no replacement)
├── composer.json
├── package.json
├── phpcs.ruleset.xml
├── readme.md
└── gatherpress.php

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carstingaxion carstingaxion added the enhancement New feature or request label Sep 26, 2024
@sc0ttkclark
Copy link

Here's an example of how I'm using that with Pods:

https://github.com/pods-framework/pods/blob/main/.github/workflows/wporg-update-versions.yml

@sc0ttkclark
Copy link

Happy to help in any way for y'all.

@carstingaxion
Copy link
Collaborator Author

Happy to help in any way for y'all.

Thank you for looking around and your kind words @sc0ttkclark !

@carstingaxion
Copy link
Collaborator Author

I created a test repo, where I placed all files in, that should in best be handled by the script (or the workflow).

Unfortunately wporg-replace is still hardly requesting for a readme.txt file.

> [email protected] wporg-replace-stable-tag
> replace 'Stable tag:(\s*)([\.\d\w\-]*)
> ' "Stable tag:\$1$npm_config_plugin_version
> " $npm_config_plugin_path/readme.txt

node:internal/fs/utils:347
    throw err;
    ^
Error: ENOENT: no such file or directory, lstat '/home/runner/work/test-wporg-replace/test-wporg-replace/readme.txt'

Would you please have look over here @sc0ttkclark ?
https://github.com/carstingaxion/test-wporg-replace/actions/runs/11077061381/job/30781510497

@carstingaxion
Copy link
Collaborator Author

carstingaxion commented Sep 27, 2024

And allow me to ask @sc0ttkclark, if it is or could be made possible, to handle other files as well, like a composer.json or even some workflow files. I updated the PR description with a list of all files, that needs to be changed.

@sc0ttkclark
Copy link

The repo is open for PRs but at the moment I have paused all WP related contributions of my own.

@carstingaxion
Copy link
Collaborator Author

Thanks for your comment @sc0ttkclark .

I mentioned your leaving on slack and saw your post in the open web. I wish you the best. May the future bring us together on another table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants