Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid import in spike detection example #33

Closed
frthjf opened this issue May 22, 2022 · 2 comments
Closed

Invalid import in spike detection example #33

frthjf opened this issue May 22, 2022 · 2 comments
Assignees
@skim0119
Labels
bug Something isn't working

Comments

@frthjf
Copy link
Contributor

frthjf commented May 22, 2022

While working on #32, I've noticed an error in examples/post_processing/spike_detection.py that appears to be caused by a stale import from miv.io import load_data. I suspect that interface in miv.io was recently updated as it does not contain a load_data function. Full stack trace can be viewed here
@frthjf frthjf added the bug Something isn't working label May 22, 2022
@skim0119
Copy link
Collaborator

Yeah, the module was updated in v0.0.4. I'll update the example file.

@skim0119 skim0119 self-assigned this May 22, 2022
@skim0119 skim0119 mentioned this issue May 22, 2022
Merged
@skim0119
Copy link
Collaborator

I've updated the example file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skim0119 skim0119

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skim0119 @frthjf