Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spike detection module #18

Merged
merged 7 commits into from
Apr 18, 2022

Conversation

skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Apr 18, 2022

resolve #13

@skim0119 skim0119 added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 18, 2022
@skim0119 skim0119 self-assigned this Apr 18, 2022
@skim0119 skim0119 changed the title 13 spike detection Add spike detection module Apr 18, 2022
@skim0119 skim0119 requested a review from armantekinalp April 18, 2022 07:48
@codecov-commenter
Copy link

Codecov Report

Merging #18 (068c9e2) into update-0.0.2 (0437c64) will increase coverage by 7.03%.
The diff coverage is 46.55%.

@@               Coverage Diff                @@
##           update-0.0.2      #18      +/-   ##
================================================
+ Coverage         30.41%   37.45%   +7.03%     
================================================
  Files                11       12       +1     
  Lines               217      251      +34     
  Branches             37       40       +3     
================================================
+ Hits                 66       94      +28     
- Misses              151      157       +6     
Impacted Files Coverage Δ
miv/signal/filter/__init__.py 100.00% <ø> (ø)
miv/signal/spike/detection.py 38.29% <36.95%> (+38.29%) ⬆️
miv/signal/spike/protocol.py 77.77% <77.77%> (ø)
miv/signal/spike/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
miv/typing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2494d24...068c9e2. Read the comment docs.

@skim0119 skim0119 merged commit c060a1d into GazzolaLab:update-0.0.2 Apr 18, 2022
@skim0119 skim0119 deleted the 13_spike_detection branch April 18, 2022 09:10
@skim0119 skim0119 mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants