Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unittest for IO module #27

Merged
merged 7 commits into from
May 16, 2022
Merged

Update unittest for IO module #27

merged 7 commits into from
May 16, 2022

Conversation

skim0119
Copy link
Collaborator

Note

  • minor bugfix
  • Add IO unittest

@skim0119 skim0119 added documentation Improvements or additions to documentation prio:mid Middle-priority issue labels May 15, 2022
@skim0119 skim0119 added this to the Version 0.1.0 milestone May 15, 2022
@skim0119 skim0119 requested a review from armantekinalp May 15, 2022 16:55
@skim0119 skim0119 self-assigned this May 15, 2022
@skim0119 skim0119 changed the base branch from main to update-0.0.3 May 15, 2022 16:55
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (update-0.0.3@ea64b4a). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             update-0.0.3      #27   +/-   ##
===============================================
  Coverage                ?   54.52%           
===============================================
  Files                   ?       18           
  Lines                   ?      475           
  Branches                ?       48           
===============================================
  Hits                    ?      259           
  Misses                  ?      216           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea64b4a...5f03f9a. Read the comment docs.

armantekinalp
armantekinalp approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 0d5e3f3 into GazzolaLab:update-0.0.3 May 16, 2022
@skim0119 skim0119 deleted the wip_coverage branch May 16, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@skim0119 skim0119

Labels
documentation Improvements or additions to documentation prio:mid Middle-priority issue
Projects
None yet
Milestone
Version 0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skim0119 @codecov-commenter @armantekinalp