Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Update on data manger and data modules #28

Merged
merged 12 commits into from
May 19, 2022

Conversation

skim0119
Copy link
Collaborator

Note

  • Add signal-to-noise ratio function
  • Add validity check on Data module
  • Update DataManager
  • Bugfix: fft, signal filter, binary to volt conversion, unit conversion

@skim0119 skim0119 self-assigned this May 19, 2022
@skim0119 skim0119 added documentation Improvements or additions to documentation enhancement New feature or request labels May 19, 2022
@skim0119 skim0119 added this to the Version 0.1.0 milestone May 19, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (update-0.0.3@0d5e3f3). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             update-0.0.3      #28   +/-   ##
===============================================
  Coverage                ?   50.00%           
===============================================
  Files                   ?       19           
  Lines                   ?      540           
  Branches                ?       58           
===============================================
  Hits                    ?      270           
  Misses                  ?      269           
  Partials                ?        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5e3f3...3e0fde7. Read the comment docs.

@skim0119 skim0119 merged commit 584eb4f into GazzolaLab:update-0.0.3 May 19, 2022
@skim0119 skim0119 deleted the wip_guide branch May 19, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants