-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connectivity guide update #53
Conversation
Codecov Report
@@ Coverage Diff @@
## update-0.1.1 #53 +/- ##
================================================
- Coverage 41.98% 40.30% -1.69%
================================================
Files 24 26 +2
Lines 724 794 +70
Branches 84 87 +3
================================================
+ Hits 304 320 +16
- Misses 418 472 +54
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I updated how to setup the workspace here. Please have it setup. You'll also need extra installation for documentation.
- Take a look at this one as well, especially second point in
key things to remember
. - Add some descriptions and references inside the documentation as well. (example)
- Rename the file:
granger_causality_psd_cpsd_coherence
. (no capital) - Plotting function can be moved to
miv/visualization/connectivity.py
(or you name it). Take a look at other files in the same folder for examples.
Added functions for causality, causality plots and spectral plots. Updated the init files in statistics and visualization. The documentation is added to docs/guide |
…into doc_connectivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @Gauravu2 I made some changes in the documentation. Please take a look.
Code for Granger Causality (Pairwise), Power and cross power spectral density, and welch coherence are added