Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burst analysis for a single channel and plotting across channels #60

Merged
merged 17 commits into from
Jun 26, 2022

Conversation

Gauravu2
Copy link
Contributor

@Gauravu2 Gauravu2 commented Jun 21, 2022

Note

Code for identifying burst and its parameters such as start time, rate, duration and length is implemented. Added in statistics

Remaining Work

  • Documentation
  • Ploltting Burst across channels

@Gauravu2 Gauravu2 added the enhancement New feature or request label Jun 21, 2022
@Gauravu2 Gauravu2 added this to the Version 0.2 milestone Jun 21, 2022
@Gauravu2 Gauravu2 requested a review from skim0119 June 21, 2022 15:05
@Gauravu2 Gauravu2 self-assigned this Jun 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #60 (82a669b) into update-0.1.1 (96fe93a) will increase coverage by 1.45%.
The diff coverage is 57.37%.

❗ Current head 82a669b differs from pull request most recent head f60495f. Consider uploading reports for the commit f60495f to get more accurate results

@@               Coverage Diff                @@
##           update-0.1.1      #60      +/-   ##
================================================
+ Coverage         40.30%   41.75%   +1.45%     
================================================
  Files                26       28       +2     
  Lines               794      855      +61     
  Branches             87       95       +8     
================================================
+ Hits                320      357      +37     
- Misses              472      493      +21     
- Partials              2        5       +3     
Flag Coverage Δ
unittests 41.75% <57.37%> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
miv/visualization/event.py 33.33% <33.33%> (ø)
miv/statistics/burst.py 65.85% <65.85%> (ø)
miv/statistics/__init__.py 100.00% <100.00%> (ø)
miv/visualization/__init__.py 100.00% <100.00%> (ø)
miv/statistics/spiketrain_statistics.py 92.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fe93a...f60495f. Read the comment docs.

@Gauravu2 Gauravu2 changed the title [WIP] Burst analysis for a single channel Burst analysis for a single channel and plotting across channels Jun 22, 2022
@Gauravu2 Gauravu2 added the documentation Improvements or additions to documentation label Jun 22, 2022
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the changes I made in #53, and make the style uniform.

@Gauravu2
Copy link
Contributor Author

Changes implemented and API documentation created . Thanks

@skim0119 skim0119 self-requested a review June 23, 2022 08:37
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write test cases for burst? I want to optimize the function a little, but I want to know what is the expected behavior beforehand.

Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added optimized code for burst

@skim0119 skim0119 merged commit a8f380e into GazzolaLab:update-0.1.1 Jun 26, 2022
@skim0119 skim0119 linked an issue Jun 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Burst Analysis
3 participants