-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burst analysis for a single channel and plotting across channels #60
Conversation
Codecov Report
@@ Coverage Diff @@
## update-0.1.1 #60 +/- ##
================================================
+ Coverage 40.30% 41.75% +1.45%
================================================
Files 26 28 +2
Lines 794 855 +61
Branches 87 95 +8
================================================
+ Hits 320 357 +37
- Misses 472 493 +21
- Partials 2 5 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the changes I made in #53, and make the style uniform.
Changes implemented and API documentation created . Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please write test cases for burst
? I want to optimize the function a little, but I want to know what is the expected behavior beforehand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added optimized code for burst
Note
Code for identifying burst and its parameters such as start time, rate, duration and length is implemented. Added in statistics
Remaining Work