Update of a GeoApp metadata returns a JSON message instead of redirecting to the GeoApp page

[giohappy]

Expected Behavior

When hitting the "Update" button either from a GeoAppsì Advanced Metadata edit or the Metadata Wizard page the user is redirected to the GepApp detail page.

Actual Behavior

A JSON string is retrurned. E.g.:

{"message": 1739}

Steps to Reproduce the Problem

1. Open any GeoApp (GeoStory)
2. Click Editing Tools -> (Metadata) Advanced Edit
3. Change a value
4. Click the Update button
5. The JSON string is returned

Specifications

• GeoNode version: 3.2.x, master
• Installation method (manual, GeoNode Docker)

[marthamareal]

@giohappy, The update on this form makes a POST request, should we also consider changing it to make a PATCH?
or we just change the response here

[giohappy]

@afabiani do you know if we're returning a JSON for the MapStore client purposes?
Anyway @marthamareal we chould change the response type depending if the request is an ajax request or not (request.is_ajax())

[marthamareal]

@giohappy this is already dome here

[giohappy]

That's curious. So why the request from the browser is treated as ajax? A flow in Django?

[marthamareal]

That's curious. So why the request from the browser is treated as ajax? A flow in Django?

It's True by default, here

[giohappy]

why is it set as a parameter on that request? Shouldn't it be set by Django as a request property???

[giohappy]

@allyoucanmap is the mapstore client using this view somehow and set this property explicitely?

[marthamareal]

The js is supposed to handle the response and then display the detail page.
However checking with my local and console, this line throws an error https://github.com/GeoNode/geonode/blob/master/geonode/templates/metadata_form_js.html#L26 and then wrong display.

[marthamareal]

@giohappy passing the UI_MANDATORY_FIELDS context here solves the issue. should i continue with it?

This is also done for layers maps and documents eg here