New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control command should be able to optionally block #136

Open

Geod24 opened this issue Jan 24, 2025 · 0 comments

Owner

Geod24 commented Jan 24, 2025

Currently, control command never block, as blocking is achieved by the client:

localrest/source/geod24/LocalRest.d

Line 1235 in 1924790

return this.conn.waitResponse(command.id, this.timeout);

This can create undesirable situations, for example when things need to be restarted in a certain order to avoid crashes.

Actually a synchronous start could also make sense 🤔

EDIT: Less of a worry because we got a channel we can wait on.

Geod24 mentioned this issue

Shutdown could call Thread.join() #137

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment