Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow launching multiple instances #104

Closed
teackot opened this issue Aug 15, 2022 · 4 comments · Fixed by #164
Closed

Allow launching multiple instances #104

teackot opened this issue Aug 15, 2022 · 4 comments · Fixed by #164
Assignees
Labels
enhancement New feature or request

Comments

@teackot
Copy link

teackot commented Aug 15, 2022

Is your feature request related to a problem? Please describe.
I find this app useful to check if two files are identical, right now I have to copy two hashes into a text editor and compare them there.

Describe the solution you'd like
Allow opening multiple windows of the app.

@teackot teackot added the enhancement New feature or request label Aug 15, 2022
@GeopJr
Copy link
Owner

GeopJr commented Aug 15, 2022

Thanks for raising this issue!

Allowing multiple instances does sound interesting and I'll definitely get on it, however your use case seems to be already covered:

  1. Open the first file by clicking on the "Open a File" button in the welcome view
    Screenshot of Collision's welcome view

  2. Select the verify tab from the headbar:
    Screenshot of Collision's Hash view
    Screenshot of Collision's Verify view

  3. Click on the button under the title "File" and select the file you want to check against:
    Screenshot of Collision's Verify view, a file was selected under the file checking section that matches the main opened file
    Screenshot of Collision's Verify view, a file was selected under the file checking section that doesn't match the main opened file

If that is not your use case, please explain it below!
If that was your use case, it appears that the current design of the Verify view is not clear enough...

(just to explain the usage of the verify tab: they are tools to check against the current open file

the text filed checks if the input matches any of the hashes of foo.txt
the file button checks if a hash of the selected file matches any of the hashes of foo.txt)

@teackot
Copy link
Author

teackot commented Aug 15, 2022

Oh! I guess I'm just blind and didn't check out the verify tab in a hurry, otherwise it's pretty obvious what this tab does. Anyway, I think multiple instances is still a good thing to have

@DodoLeDev
Copy link
Contributor

With the ability to open files directly from the command line, you are “theoretically” able to open multiple files with Collision.
But for now, the program just doesn't handle it correctly!
It seems that launching a new instance of Collision......merges the window content with the already-existing window! xD

First file Second file Sum of both
Capture d’écran du 2022-11-21 20-52-41 Capture d’écran du 2022-11-21 20-52-53 Capture d’écran du 2022-11-21 20-53-40

@GeopJr
Copy link
Owner

GeopJr commented Nov 21, 2022

Nice catch! Thanks for the report!

It should be fixed as of #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants