Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Ability to edit Mastodon toots / statuses #172

Closed
1 of 4 tasks
nekohayo opened this issue Apr 7, 2023 · 4 comments
Closed
1 of 4 tasks

[Request]: Ability to edit Mastodon toots / statuses #172

nekohayo opened this issue Apr 7, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@nekohayo
Copy link

nekohayo commented Apr 7, 2023

Describe the request

As a famous person once said,

I was today years old when I learned Mastodon actually supports editing statuses. What.
https://docs.joinmastodon.org/methods/statuses/#edit

Indeed, the Mastodon web UI is a prime example of this feature working. I'd want this ability in Tuba too.

Maybe other protocols support it too; I have no idea. I only use Tuba for Mastodon.

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@bleakgrey
Copy link
Contributor

This should be closed. When creating new issues, please double check if suggested functionality has already been implemented.

@GeopJr
Copy link
Owner

GeopJr commented Apr 7, 2023

As Bleak said, this is already in, right click / long-tap a post you made and select Edit

@GeopJr GeopJr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2023
@nekohayo
Copy link
Author

nekohayo commented Apr 7, 2023

Oh, I now see why I thought this was not yet implemented… when you are inside a discussion thread and right-click in the middle of a status you posted yourself, there is no such thing as an Edit action. There only are the text selection actions (most of which, like "Cut" and "Paste", don't make sense because this is not actually an area where you can ever do such actions):

image

i.e. the wrong menu shows up under some circumstances. That's the bug. I thought it happened everywhere, but I just so happened to be under "just the right set of UI circumstances" for it to happen to me while reporting.

I guess the bug report would then be:

  • The action items right-click menu should occur even when right-clicking text within a thread, replacing the vanilla (but useless) text selection right-click menu
  • The replaced text selection right-click menu's "Copy" action could be added to a dedicated action item (not needing to make a selection first) to this menu, if you want to preserve that ability.

Makes sense?

@GeopJr
Copy link
Owner

GeopJr commented Apr 7, 2023

That context menu is actually right, in thread mode (only) all statuses are selectable (you can select portions of the text and copy etc). If you right click outside the label (like above the user avatar) it will show the post context menu.

While I agree that most of the items there are useless in the context of non-editable label, more thought is needed on how it should be handled. Ideally the post context menu should be a button. Either way, duplicate of #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants