Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pull to refresh works with touchscreen mobile device but does not work in desktop app with touchpad #393

Closed
CaptainMorgan12 opened this issue Jul 19, 2023 · 4 comments · Fixed by #505
Labels
bug Something isn't working

Comments

@CaptainMorgan12
Copy link

CaptainMorgan12 commented Jul 19, 2023

Describe the bug

Should be standardized. Using a single finger in timeline on touchscreen it pulls to refresh with animation. However using two fingers on touchpad on desktop device it does not. See feature implementation #283

Steps To Reproduce

  1. on desktop with touchpad scroll to timeline top
  2. swipe two fingers down
  3. observe no pull to refresh animation or reload occurs

Logs and/or Screenshots

os: GNOME 44 (Flatpak runtime)
prefix: /app
flatpak: true
version: 0.4.0 (production)
gtk: 4.10.3 (4.10.3)
libadwaita: 1.3.2 (1.3.2)
libsoup: 3.4.2 (3.4.2)
libgtksourceview: 5.8.0 (5.8.0)

Instance Backend

I'm not sure / Other

Operating System

Ubuntu 23.04

Package

Flatpak

Troubleshooting information

Compare to mobile touch screen device behaviour.

Additional Context

No response

@CaptainMorgan12 CaptainMorgan12 added the bug Something isn't working label Jul 19, 2023
@alice-mkh
Copy link
Contributor

This would be tricky to fix. Possibly impossible - GtkScrolledWindow really doesn't cooperate well with other gestures, same as how back swipes are broken. Even in GTK3 where those worked they only worked when there's no horizontal scrolling, and here it's vertical scrolling + vertical pull to refresh swipe.

@GeopJr
Copy link
Owner

GeopJr commented Jul 19, 2023

FWIW, you can still trigger it with a touchpad by dragging it from the top

output

As for the ScrolledWindow,the initial implementation (ab)used the overshot, not sure if it's worth adding it again since dragging works just fine:

#155 (comment)

@alice-mkh
Copy link
Contributor

Yeah, I wouldn't. Note that it's also pretty broken on touchscreen atm.

@CaptainMorgan12
Copy link
Author

CaptainMorgan12 commented Jul 20, 2023

true drag and pull works, thanks for pointing that out! for consistency though would it be better to try to align touch on touch screen device interaction and touchpad on desktop app interactions, if possible (also maybe once you reach the beginning of timeline maybe having some small text on top that says "Drag/Pull to Refresh" would be a good que?

@GeopJr GeopJr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants