Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Headerbar conditions regression #734

Closed
IBBoard opened this issue Jan 2, 2024 · 0 comments · Fixed by #735
Closed

[Bug]: Headerbar conditions regression #734

IBBoard opened this issue Jan 2, 2024 · 0 comments · Fixed by #735
Labels
bug Something isn't working

Comments

@IBBoard
Copy link

IBBoard commented Jan 2, 2024

Describe the bug

#575 has come back - Tuba isn't showing the view switcher at narrow-but-not-narrow-enough-to-put-the-buttons-at-the-bottom sizes. It appears to be due to #651 fixing race conditions but breaking the initial value.

Steps To Reproduce

  1. Open Tuba with a default width of 555px
  • Expected: Title bar contains view switcher
  • Actual: Title bar contains title.
  1. Resize Tuba below 550px
  2. Resize Tuba above 550px
  3. View switcher is shown

Logs and/or Screenshots

No response

Instance Backend

Mastodon

Operating System

openSuse Tumbleweed

Package

Compiled manually

Troubleshooting information

os: openSUSE Tumbleweed (null)
prefix: /usr
flatpak: false
version: -6793a3c (development)
gtk: 4.12.4 (4.12.4)
libadwaita: 1.4.2 (1.4.2)
libsoup: 3.4.4 (3.4.4)
libgtksourceview: 5.10.0 (5.10.0)

Additional Context

Built 8038e8f - broken.
Built 6793a3c (previous commit, before #651 merged) - correct behaviour.
Tried manually adding some of the old hooks back without any luck.
Added info() calls to TabbedBaseView.title_stack_page_visible but it doesn't log until the resize. So the breakpoint appears not to be handling the default size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant