New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This repo uses numpy.bool which is not compatible with recent versions of numpy #328

Open

SpacemanPaul opened this issue Jun 19, 2023 · 1 comment

SpacemanPaul commented Jun 19, 2023

As reported on Slack, the numpy.bool type is used in https://github.com/GeoscienceAustralia/digitalearthau/blob/develop/digitalearthau/utils.py (and possibly elsewhere in this repo).

Recent versions of numpy fail on this with an AttributeError:

np.bool was a deprecated alias for the builtin bool. To avoid this error in existing code, use bool by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.bool_ here.
The aliases was originally deprecated in NumPy 1.20

The text was updated successfully, but these errors were encountered:

Member

robbibt commented Jun 19, 2023

I would have a preference to deprecate the wofs_fuser function here, and instead re-direct users to the copy of the function inside dea_tools: https://github.com/GeoscienceAustralia/dea-notebooks/blob/develop/Tools/dea_tools/datahandling.py#L681-L691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment