Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile to ES5? #14

Closed
GerHobbelt opened this issue Sep 12, 2017 · 2 comments
Closed

Compile to ES5? #14

GerHobbelt opened this issue Sep 12, 2017 · 2 comments

Comments

@GerHobbelt
Copy link
Owner

Latest jison 0.6.0-191 uses a few ES2016 features (string templates, ...args) which are not supported in older NodeJS and/or browsers (Node 5.0 and older: TravisCI fails ATM: https://travis-ci.org/GerHobbelt/jison )

It might be advisable to pull jison et al through babel before publishing in order to prevent issues stemming from running jison in older environments.

Note:
extra checks required to ensure the generated parsers and lexers are ES5 safe!

@GerHobbelt
Copy link
Owner Author

Relevant common code which was done in ES6 (at least some bits of it) has been moved to a separate subrepo: https://github.com/GerHobbelt/jison-helpers-lib and is babel-compiled in the build process there.

That at least covers it for the TravisCI tests in Node 4 and Node 5 environments.

Which leaves rollup+babel support for the entire thing...

@GerHobbelt
Copy link
Owner Author

Done. jison and its libraries/packages are now processed through rollup+babel and the monolithic results are presented in the various dist/ distribution directories.

The only thing that still bothers me is compiling ES6-action-code-carrying grammars in non-ES6 environments (NodeJS, among others) but that is a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant