-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child reactions of child reactions do not get updated properly #304
Comments
Hi, we're seeing the same, or a very similar issue. |
In case it helps, this is the gist of what we're doing: <CommentList
activityId={someActivityId}
CommentItem={(comment_props) => (
...
<CommentField activity={comment_props.comment} />
)}
/> |
Hey, @antishok! Sadly, no update yet, but the reply functionality (activity -> comment -> reply comment) is unaffected by this. It's the children of reply comments (likes or other sub-reply comments) that cause this issue, which is also a maximal nesting depth allowed by the BE. |
Thanks for the reply @arnautov-anton. Can you please confirm that the usage I showed above is correct? Thanks again! |
Sure! Here's a simple example I've been using for testing - works fine without the likes on the replies. Yours seems to be pretty close to how it's used normally but feel free to try it out and let me know if you're still experiencing the issues. Also I'm sorry about the missing documentation - we're currently working on it and we plan to release it as soon as it's finished. Sorry for the inconvenience. |
Thanks for the example. |
Figured it out - and your method indeed seems to work, so thanks a lot. |
I've modified |
Hey again, @antishok! I missed your point at first but I understand now, I'll create a separate issue to extend current |
Facing the same issue, when we "created comment -> replied to comment => liked comment reply - > error is thrown". |
When user creates a reply comment to a parent reaction and then right after tries to create another child reaction to that newly created child reaction (of kind
like
in this instance) - theown_children
key (and basically other keys also) of that object won't get updated properly. The application crashes while trying to find path withFeedManager.getReactionPaths
which returnsundefined
inFeedManager.onToggleChildReaction
or later inFeedManager.onAddChildReaction
.Screen.Recording.2021-09-24.at.12.22.02.PM.mov
The text was updated successfully, but these errors were encountered: