Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable margin between own image message and following text message #152

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

MartinCupela
Copy link
Collaborator

🎯 Goal

Margins between own image message and text message were collapsed. This was due to use of display: flex on .str-chat__message-simple--me container. This was not happening between the image and text message of other channel members.

🎨 UI Changes

Before:
image

After:
image

@MartinCupela MartinCupela requested a review from oliverlaz July 15, 2022 13:30
@MartinCupela MartinCupela changed the title fix: enable margin between image message and following text message fix: enable margin between own image message and following text message Jul 15, 2022
@MartinCupela MartinCupela merged commit d92b625 into develop Jul 15, 2022
@MartinCupela MartinCupela deleted the fix/margin-btw-image-and-text-message branch July 15, 2022 14:01
@MartinCupela MartinCupela mentioned this pull request Jul 15, 2022
github-actions bot pushed a commit that referenced this pull request Jul 15, 2022
## [2.10.1](v2.10.0...v2.10.1) (2022-07-15)

### Bug Fixes

* enable margin between image message and following text message ([#152](#152)) ([5f00862](5f00862))
* enable margin between image message and following text message ([#152](#152)) ([d92b625](d92b625))
@szuperaz
Copy link
Collaborator

🎉 This PR is included in version 2.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Aug 25, 2022
# [3.0.0-theming2.7](v3.0.0-theming2.6...v3.0.0-theming2.7) (2022-08-25)

### Bug Fixes

* Angular image modal width ([4ae35e5](4ae35e5))
* enable margin between image message and following text message ([#152](#152)) ([d92b625](d92b625))

### Features

* Disable attachments interactions on quoted messages ([7cfaf79](7cfaf79))
@szuperaz
Copy link
Collaborator

🎉 This PR is included in version 3.0.0-theming2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants