Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error message and download icon to voice recordings #280

Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat: add error message and download icon to voice recordings #280

merged 1 commit into from
Mar 25, 2024

Conversation

szuperaz
Copy link
Collaborator

@szuperaz szuperaz commented Mar 25, 2024 •
edited
Loading

🎯 Goal

  • Add error message to voice recording
  • Add download icon to voice recording -> Angular will be released without downloading (there are some issues downloading memos from Android and RN) but I pushed the markup if the issues are fixed, we can just easily turn this on
  • Adjust angular template for file attachments -> previously clicking anywhere in the attachment markup downloaded the file, now only clicking on the file name or download icon will cause download

🛠 Implementation details

This is currently Angular-only, React can follow with implementation

🎨 UI Changes

Markup with error message + download icon
Screenshot 2024-03-25 at 13 08 06

Since we have some problems with downloads, the released markup in the Angular SDK won't feature a link to download the voice memo:

Screenshot 2024-03-25 at 13 21 41

Make sure to test with both Angular and React (with both MessageList and VirtualizedMessageList components) SDKs

@szuperaz szuperaz force-pushed the voice-message-error-message branch from b70b599 to 810fb30 Compare March 25, 2024 12:24
@szuperaz szuperaz merged commit d01270f into main Mar 25, 2024
@szuperaz szuperaz deleted the voice-message-error-message branch March 25, 2024 12:48
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
@semantic-release-bot
chore(release): 4.10.0 [skip ci]
8bd821a 
# [4.10.0](v4.9.2...v4.10.0) (2024-03-25)

### Bug Fixes

* make wavebar data responsive ([#279](#279)) ([796dc89](796dc89))

### Features

* add error message and download icon to voice recordings ([#280](#280)) ([d01270f](d01270f))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinCupela MartinCupela Awaiting requested review from MartinCupela

@myandrienko myandrienko Awaiting requested review from myandrienko

@oliverlaz oliverlaz Awaiting requested review from oliverlaz

@arnautov-anton arnautov-anton Awaiting requested review from arnautov-anton

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szuperaz