Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary margin from error messages #74

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

szuperaz
Copy link
Collaborator

@szuperaz szuperaz commented Apr 5, 2022

Error message display is broken both for React and Angular

Before fix:
React:
Screenshot 2022-04-05 at 15 16 02
Angular:
Screenshot 2022-04-05 at 15 14 36

After fix:
React:
Screenshot 2022-04-05 at 15 33 23
Angular:
Screenshot 2022-04-05 at 15 29 22

@szuperaz szuperaz requested review from petyosi and arnautov-anton and removed request for petyosi April 5, 2022 13:44
Copy link
Collaborator

@arnautov-anton arnautov-anton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@arnautov-anton arnautov-anton merged commit 5439779 into develop Apr 7, 2022
@arnautov-anton arnautov-anton deleted the error-message-fix branch April 7, 2022 08:05
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
## [2.8.1](v2.8.0...v2.8.1) (2022-04-08)

### Bug Fixes

* add missing dark theme styling for messaging app ([#76](#76)) ([ec84a43](ec84a43))
* Message overflow in thread & display command list above upload previews ([#75](#75)) ([74a88bd](74a88bd))
* Remove unnecessary margin from error messages ([#74](#74)) ([5439779](5439779))
@szuperaz
Copy link
Collaborator Author

szuperaz commented Apr 8, 2022

🎉 This PR is included in version 2.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants