Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unread count to not increment if channel has read_events off #904

Merged
merged 6 commits into from
Feb 24, 2022

Conversation

khushal87
Copy link
Member

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

If the read events are turned off on the application, then the unread count shouldn’t show up on the channel list component. Currently, when a new message comes in, we increment the unread count for a particular channel. But this increment works even if read events are turned off, which leads to confusing behavior.

Changelog

  • Add the logic for not incrementing channel unread count if the read_events are off.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022

Size Change: +443 B (0%)

Total Size: 285 kB

Filename Size Change
dist/browser.es.js 62.2 kB +98 B (0%)
dist/browser.full-bundle.min.js 34.5 kB +58 B (0%)
dist/browser.js 62.9 kB +97 B (0%)
dist/index.es.js 62.3 kB +96 B (0%)
dist/index.js 62.9 kB +94 B (0%)

compressed-size-action

vishalnarkhede
vishalnarkhede previously approved these changes Feb 10, 2022
src/channel.ts Outdated Show resolved Hide resolved
@vishalnarkhede vishalnarkhede merged commit 75ebc95 into master Feb 24, 2022
@vishalnarkhede vishalnarkhede deleted the khushal87-crns-518 branch February 24, 2022 12:37
@github-actions github-actions bot mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants