Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelSort<StreamChatGenerics> looks at the wrong fields #915

Closed
andreibarabas opened this issue Feb 28, 2022 · 2 comments · Fixed by #941
Closed

ChannelSort<StreamChatGenerics> looks at the wrong fields #915

andreibarabas opened this issue Feb 28, 2022 · 2 comments · Fixed by #941
Assignees
@khushal87

Comments

@andreibarabas
Copy link

If we have a channel with custom props, those props are not recognised anymore due to the fact that ChannelSort now looks at the generic instance instead of the 'channelType' field
@andreibarabas andreibarabas mentioned this issue Feb 28, 2022
Closed
2 tasks
@petyosi
Copy link
Contributor

petyosi commented Mar 28, 2022

@khushal87 can you take a look?

@khushal87
Copy link
Member

Sure @petyosi

@khushal87 khushal87 mentioned this issue Apr 1, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khushal87 khushal87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: types of fields in ChannelSort GetStream/stream-chat-js
3 participants
@petyosi @andreibarabas @khushal87