Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS63VR Wave mode doesn't work #17

Open
AbsyntheSyne opened this issue May 3, 2018 · 7 comments
Open

GS63VR Wave mode doesn't work #17

AbsyntheSyne opened this issue May 3, 2018 · 7 comments

Comments

@AbsyntheSyne
Copy link

Wave mode doesn't work. It used to work previously, I don't remember what commit. I type in sudo msiklm wave and it does nothing.

@Gibtnix
Copy link
Owner

Gibtnix commented May 3, 2018

Did you try the current version from the repo? A few days ago I merged a PR as there was a small bug related to the wave mode (!= sign instead of ==), if your version is not up-to-date, it is likely to be the reason. The current version's wave mode definitely works on my side.

@AbsyntheSyne
Copy link
Author

AbsyntheSyne commented May 3, 2018

Yes I do. It refuses to work for me, even if I do a direct path sudo /usr/local/bin/msiklm wave it doesn't work.

@Gibtnix
Copy link
Owner

Gibtnix commented May 3, 2018

Strange... could you please try all of the following commands if any works (there are different ways how the program works, so maybe please try all three)

  • sudo msiklm green wave
  • sudo msiklm green,blue,red high wave
  • sudo msiklm green high wave

If none of these work, I'll prepare a special version for you to try to locate the problem.

@AbsyntheSyne
Copy link
Author

AbsyntheSyne commented May 3, 2018

  • no

  • yes

  • yes

although doing sudo msiklm red,green,blue high wave doesn't do anything. This is normally what I do.

edit: red,blue,green seems to work fine, however.

@Gibtnix
Copy link
Owner

Gibtnix commented May 7, 2018

First it seems that explicitly supplying the brightness 'high' is important. Internally the default value is 'rgb' such that the rgb-color setting is used (cf. set_color() in msiklm.c), you can switch this to predefined colors by using low, medium or high instead. So the latter two commands I asked you to test are especially interesting as they use the explicit brightness (and thus, are switching to predefined mode) and it seems to work so far. So I would conclude that your keyboard requires to use the predefined color mode.

But I cannot explain why 'sudo msiklm red,green,blue high wave' does not work while 'sudo msiklm red,blue,green high wave' does - the commands are equivalent with respect to mode setting as long as you explicitly supply 'high' brightness. Color parsing also works, I verified this once more.

@AbsyntheSyne
Copy link
Author

Yeah I don't know what's up, but it's really confusing. Any ideas why this is happening?

@Gibtnix
Copy link
Owner

Gibtnix commented May 7, 2018

Maybe you could try to first set the colors (either using rgb or predefined mode - i.e. with or without brightness argument) first and then use a second call that only sets the mode... at least would be worth a try I think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants