Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a gphCellPadding bug? #107

Closed
KimDandan opened this issue Dec 9, 2020 · 5 comments
Closed

Is this a gphCellPadding bug? #107

KimDandan opened this issue Dec 9, 2020 · 5 comments

Comments

@KimDandan
Copy link

Hi,
I am using GiphyGridView.
I set gphSpanCount to 5 and gphCellPadding to 20dp.
The size(width) of the items in (1, 5) column and (2, 3, 4) column looks different.
Is this normal? Or is it a bug?
please answer about my question.

GIPHY sdk version: 2.0.6
device: Samsung Galaxy S8 (Android9), Samsung Galaxy S10 (Android10)

xml code :

<com.giphy.sdk.ui.views.GiphyGridView
            android:id="@+id/sticker_list"
            android:layout_width="0dp"
            android:layout_height="0dp"
            app:gphCellPadding="20dp"
            app:gphDirection="vertical"
            app:gphShowCheckeredBackground="false"
            app:gphSpanCount="5"
            app:layout_constraintBottom_toBottomOf="parent"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toTopOf="parent" />

Screenshot before/after cellPadding setting :

cell_padding_1

cell_padding_2

(If gphSpanCount is 3 or more and gphCellPadding is set, it seems that the size(width) of the items at both ends and the rest of the column will be different.)

@ALexanderLonsky
Copy link
Collaborator

@KimDandan hey, I'll look into this and let you know.

@ALexanderLonsky
Copy link
Collaborator

@KimDandan thanks for flagging this - i’ve been able to reproduce. i’ll include a fix in a future release.

@KimDandan
Copy link
Author

@ALexanderLonsky Thank you for confirming!

@ALexanderLonsky
Copy link
Collaborator

@KimDandan please try v2.0.7

@KimDandan
Copy link
Author

@ALexanderLonsky I checked. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants