Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16KB support for native libraries - urgent #230

Closed
deepti1408 opened this issue Jan 3, 2025 · 2 comments
Closed

16KB support for native libraries - urgent #230

deepti1408 opened this issue Jan 3, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@deepti1408
Copy link

🐛 Bug Report

Giphy latest update 2.3.15 uses older version of fresco lib. The latest fresco lib https://github.com/facebook/fresco/releases/tag/v3.4.0 has 16KB support android 15 devices. https://developer.android.com/guide/practices/page-sizes#:~:text=Beginning%20with%20Android%2015%2C%20AOSP,on%20these%2016%20KB%20devices.
So the current giphy lib causes app to crash

To Reproduce

App crashes on 16 KB devices running android 15.

Expected behavior

app should not crash.

Actual Behavior

App crashes on 16 KB devices running android 15.

Your Environment

  • Giphy Android SDK version: 2.3.15
  • Device info (Emulator/Device? Android version? Debug/Release?): 16 KB devices running android 15.

Reproducible Demo

@deepti1408 deepti1408 added the bug Something isn't working label Jan 3, 2025
@ALexanderLonsky
Copy link
Collaborator

Hey @deepti1408,
thanks for flagging this issue!

Unfortunately, it will take some time to release a new version that supports Fresco 3.4.0.
This update requires upgrading the Gradle and Kotlin versions. We also need to ensure it integrates smoothly with our Flutter and React Native SDKs, which serve as wrappers around the Android SDK. In the meantime, you can resolve the issue by forcing Fresco to version 3.4.0 in your project.

Add the following to your build.gradle, placing it just before dependencies section:

configurations.configureEach {
    resolutionStrategy {
        forcedModules = ['com.facebook.fresco:fresco:3.4.0',
                         'com.facebook.fresco:animated-gif:3.4.0',
                         'com.facebook.fresco:animated-base:3.4.0',
                         'com.facebook.fresco:animated-drawable:3.4.0',
                         'com.facebook.fresco:animated-webp:3.4.0',
                         'com.facebook.fresco:webpsupport:3.4.0',
                         'com.facebook.fresco:imagepipeline-okhttp3:3.4.0',
                         'com.facebook.fresco:middleware:3.4.0',
                         'com.facebook.fresco:nativeimagetranscoder:3.4.0',
        ]
    }
}

The issue was resolved on my end.
After running the check_elf_alignment.sh script, the output changed from:
Found 5 unaligned libs (only arm64-v8a/x86_64 libs need to be aligned)
to:
ELF Verification Successful

@ALexanderLonsky
Copy link
Collaborator

The new version with the fix is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants