Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GiphyGridController.numberOfTracks for iPad #134

Closed
chenshengzhi opened this issue Jan 19, 2021 · 3 comments
Closed

GiphyGridController.numberOfTracks for iPad #134

chenshengzhi opened this issue Jan 19, 2021 · 3 comments

Comments

@chenshengzhi
Copy link

GiphyGridController.numberOfTracks is limited between 0 and 5.
So cells size is too big for iPad.
Please remove this limitation.
Thanks

@cgmaier
Copy link
Contributor

cgmaier commented Jan 27, 2021

thanks @chenshengzhi we'll include this change in the next release.

@chenshengzhi
Copy link
Author

🎉 Thank you

@cgmaier
Copy link
Contributor

cgmaier commented Feb 4, 2021

hey @chenshengzhi this limitation is removed in the latest release
https://github.com/Giphy/giphy-ios-sdk-ui-example/releases/tag/v2.1.2
thanks!

@cgmaier cgmaier closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants