Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects count stats are incorrect #34

Closed
divine-comedian opened this issue Jul 30, 2024 · 10 comments
Closed

projects count stats are incorrect #34

divine-comedian opened this issue Jul 30, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@divine-comedian
Copy link
Contributor

Testing the Projects Count feature on https://stats.giveth.io/ appear to be incorrect.

Checking the count of projects we can see on the dapp it says we have 2812 listed project - but on the analytics dashboard it says we have 2914 - which one is correct? They should be the same number...

Image

We should also add an option to "exclude externally imported projects" this would be a checkbox that would exclude projects we've imported from another app such as The Giving Block, Change.org or Endaoment.

When the box is checked we should then exclude those projects and show only Giveth projects that have been created directly on our platform

@divine-comedian divine-comedian added the bug Something isn't working label Jul 30, 2024
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jul 30, 2024
@ae2079
Copy link
Collaborator

ae2079 commented Aug 6, 2024

@divine-comedian
As I should spend all of my capacity on the Qacc project, I can not do this issue in the next 6 weeks, so I unassigned this issue from myself

@ae2079 ae2079 removed their assignment Aug 6, 2024
@RamRamez
Copy link
Collaborator

RamRamez commented Aug 6, 2024

@Reshzera could you please take this issue?
cc @jainkrati

@Reshzera
Copy link
Contributor

Reshzera commented Aug 6, 2024

@RamRamez Sure

@RamRamez RamRamez moved this from New Issues to In Progress in All-Devs Aug 7, 2024
@Reshzera Reshzera moved this from In Progress to Code Review/PR in All-Devs Aug 7, 2024
@RamRamez
Copy link
Collaborator

RamRamez commented Aug 7, 2024

@Reshzera investigated and noticed that on all projects page we fetch only active projects but on analytics dashboard we fetch them all.
@divine-comedian is it ok to change the analytics dashboard to show only active projects?

@divine-comedian
Copy link
Contributor Author

Got it, so the projects count in analytics is counting deactivated and cancelled projects..

let's go ahead and make your suggested changes @RamRamez - and rename the query header text to "Active Projects Count"

@RamRamez
Copy link
Collaborator

RamRamez commented Aug 9, 2024

@Reshzera I've commented on your PR, it needs a tiny change, please fix it, also in analytics-dashboard please change the title of "Projects Count" to "Active Projects Count"

@divine-comedian
Copy link
Contributor Author

@Reshzera what is the update on this issue?

@Reshzera
Copy link
Contributor

@divine-comedian I didn't have seen this comment, I'm sorry. I'll fix it

@Reshzera Reshzera moved this from Code Review/PR to QA in All-Devs Aug 23, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Aug 26, 2024

@LatifatAbdullahi Can you please pick this up?

@LatifatAbdullahi
Copy link

Test Udpdate

Stage

This works as expected on Stage

ex
inm

The title has also been updated to Active Project Counts

ac

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Aug 26, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged to Production
Development

No branches or pull requests

6 participants