Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

Getting refund/canceling is too easy #80

Closed
2 tasks
vojtechsimetka opened this issue Oct 18, 2017 · 15 comments
Closed
2 tasks

Getting refund/canceling is too easy #80

vojtechsimetka opened this issue Oct 18, 2017 · 15 comments
Labels
help wanted Issues that are clear and can be picked by contributors.

Comments

@vojtechsimetka
Copy link
Collaborator

vojtechsimetka commented Oct 18, 2017

Several non-recoverable actions are too easy to perform in the DApp. These are:

  • Cancel Milestone
  • Delete Milestone
  • Cancel Campaign
  • Refund donation

The buttons for these actions should be visible, but the confirmation should be more difficult like deleting a Github Repository.

Task:

  • Create popup component for non-trivial actions that will ask to copy the title of the Milestone/Campaign or the amount of donation (first 5 digits)
  • Replace the confirmation flow for these actions with the newly created component

Example how it looks on Github
screen shot 2018-07-10 at 23 40 31
screen shot 2018-07-10 at 23 40 31

@vojtechsimetka vojtechsimetka added feedback for redesign Feedback and suggestions to be taken into account for redesign and are not issues to be tackled now. and removed UX labels Apr 14, 2018
@vojtechsimetka vojtechsimetka added this to the Redesign milestone Apr 15, 2018
@vojtechsimetka vojtechsimetka changed the title Getting a refund is too easy Getting refund/canceling is too easy Jul 10, 2018
@vojtechsimetka vojtechsimetka added help wanted Issues that are clear and can be picked by contributors. and removed feedback for redesign Feedback and suggestions to be taken into account for redesign and are not issues to be tackled now. labels Jul 10, 2018
@vojtechsimetka
Copy link
Collaborator Author

@anshumanv @vs77bb How do you like this one? More are coming :).

@anshumanv
Copy link
Contributor

This is super interesting! 😮

I'll surely love working on this. 🎉
cc @vs77bb

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Jul 18, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 6 months, 3 weeks ago.
Please review their action plans below:

1) anshumanv has started work.

Nothing so far, I'll follow up if I'm stuck somewhere, excited!

Learn more on the Gitcoin Issue Details page.

@anshumanv
Copy link
Contributor

Hey @vojtechsimetka 👋 Super excited to work with you again! 😄

I tried reproducing the issue and wanted to clarify about 2 parts,

  • I'm no longer to make the donations since I think some changes are done recently and wallet doesn't have anymore ETH to test maybe? It ways insufficient balance when I try to make donations.
  • I see the options to cancel milestone/campaign, where's the option to delete milestone? 😅

@vojtechsimetka
Copy link
Collaborator Author

Hey @anshumanv sorry for late response:

I'm no longer to make the donations since I think some changes are done recently and wallet doesn't have anymore ETH to test maybe? It ways insufficient balance when I try to make donations.

Yes we have change the DApp so that you have to use external web3 provider to donate. All you need to do is import one of the keystores to metamask.

I see the options to cancel milestone/campaign, where's the option to delete milestone?

Milestones can be deleted only when they are proposed (meaning you "create" a milestone in campaign that is not made by you) and they can be deleted only until they are accepted by the Campaign lead.

@anshumanv
Copy link
Contributor

Yes we have change the DApp so that you have to use external web3 provider to donate. All you need to do is import one of the keystores to metamask.

Okay, lost track of the recent changes, will try this.

Milestones can be deleted only when they are proposed (meaning you "create" a milestone in campaign that is not made by you) and they can be deleted only until they are accepted by the Campaign lead.

Makes sense, I'll try playing around with it. 👍

Thanks for the help again @vojtechsimetka 😄

@anshumanv
Copy link
Contributor

Hey @vojtechsimetka how about adding a text field to the sweetalert popup as we're using right now?
image

@vojtechsimetka
Copy link
Collaborator Author

Yeah that works :). Can you also highlight (just like this) the par that needs to be copied?

@gitcoinbot
Copy link

@anshumanv Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@anshumanv
Copy link
Contributor

I'll complete this today.

@vs77bb
Copy link

vs77bb commented Jul 30, 2018

How's this going @anshumanv? Hope you're doing well 🙂

@anshumanv
Copy link
Contributor

Hey @vs77bb I'm at my best and hoping for you the same. This is almost done and a WIP PR is at #443 the task is completed, just need some refactoring, will be doing this tomorrow. 👍 ❇️ Thanks for checking it up!

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by:

  1. @anshumanv

@vs77bb please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @anshumanv.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues that are clear and can be picked by contributors.
Projects
None yet
Development

No branches or pull requests

4 participants