Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to my recurring donations page for handling base network #4884

Closed
22 tasks
divine-comedian opened this issue Nov 28, 2024 · 16 comments
Closed
22 tasks
Assignees

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Nov 28, 2024

We should make some new updates to the my recurring donations page to ensures users understand recurring donations happening on different networks.

Image

image

AC

Base

  • User can see network column with relevant network icon for stream balances table
  • user can see balance of streamable tokens on Base
  • user can see active,pending and ended (not archived) recurring donations on base & optimism
  • amount donated monthly, total donated $ amounts and token amounts are corrected and update ever y ~24 hours
  • user can filter recurring donations by network, token symbol or by active/ended state
  • when filtering by token symbol it shows tokens with same symbol across multiple networks (e.g ETH on both Optimism and Base)
  • user can successfully deposit more tokens to stream balance for tokens on Base
  • user can successfully withdraw some tokens from stream balance on Base. Note: If user has stream balance with some active recurring donations using it they will not be able to withdraw 100% of their balance
  • users can end an active recurring donation on Base.
  • users can select ended recurring donation on Base and choose action to start a new one
  • user can select ended recurring donation on Base and archive it

Regression Test

  • user can see balance of streamable tokens on Optimism
  • amount donated monthly, total donated $ amounts and token amounts are corrected and update every ~24 hours for Optimism
  • user can successfully deposit more tokens to stream balance for tokens on Optimism
  • user can successfully withdraw some tokens from stream balance on Optimism. Note: If user has stream balance with some active recurring donations using it they will not be able to withdraw 100% of their balance
  • users can end an active recurring donation on Optimism.
  • users can select ended recurring donation on Optimism and choose action to start a new one
  • user can select ended recurring donation on Optimism and archive it

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Nov 28, 2024
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Nov 28, 2024
@divine-comedian divine-comedian added this to the SuperFluid Drop milestone Dec 3, 2024
@divine-comedian

This comment has been minimized.

@kkatusic kkatusic moved this from Dev Research to In Progress in All-Devs Dec 19, 2024
@divine-comedian

This comment has been minimized.

@divine-comedian divine-comedian moved this from In Progress to Code Review/PR in All-Devs Dec 23, 2024
@divine-comedian

This comment has been minimized.

@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Dec 26, 2024
@LatifatAbdullahi
Copy link

Test Update @kkatusic @divine-comedian

Base

  • User can see network column with relevant network icon for stream balances table - Pass
  • User can see balance of streamable tokens on Base - Pass
  • User can see active,pending and ended (not archived) recurring donations on base & optimism - Pass
  • Amount donated monthly, total donated $ amounts and token amounts are corrected and update ever y ~24 hours - Pending
  • User can filter recurring donations by network, token symbol or by active/ended state - Pass
  • When filtering by token symbol it shows tokens with same symbol across multiple networks (e.g ETH on both Optimism and Base) - Pass
  • User can successfully deposit more tokens to stream balance for tokens on Base - Pass
  • User can successfully withdraw some tokens from stream balance on Base. Note: If user has stream balance with some active recurring donations using it they will not be able to withdraw 100% of their balance - Pass
  • Users can end an active recurring donation on Base - Pass
  • Users can select ended recurring donation on Base and choose action to start a new one - Pass
  • Users can select ended recurring donation on Base and archive it - Pass

Regression Test

  • Users can see balance of streamable tokens on Optimism - Pass
  • Amount donated monthly, total donated $ amounts and token amounts are corrected and update every ~24 hours for Optimism - Pending
  • Users can successfully deposit more tokens to stream balance for tokens on Optimism - Pass
  • Users can successfully withdraw some tokens from stream balance on Optimism. Note: If user has stream balance with some active recurring donations using it they will not be able to withdraw 100% of their balance - Pass
  • Users can end an active recurring donation on Optimism - Pass
  • Users can select ended recurring donation on Optimism and choose action to start a new one - Pass
  • Users can select ended recurring donation on Optimism and archive it - Pass

Issues

1**. "Cancel" button on the "Archive" modal not working as expected**

image
  1. Switching to "Archive donations" still shows active and pending donation instead of only archived donations
image image

@divine-comedian
Copy link
Contributor Author

@LatifatAbdullahi

Two things

  1. Could you specify what is not behaving as expected on cancel button
  2. The expected behaviour for the archive toggle is to show or hide archived recurring donations. It is expected that the active and pending donations will ALWAYS be shown, regardless of toggle state. Sorry for not clarifying earlier!

@LatifatAbdullahi
Copy link

Thanks for the clarification @divine-comedian

  1. Clicking on the cancel button does not return any action i.e closing the modal (please let me know if this is not the expected action)

image

@divine-comedian
Copy link
Contributor Author

yes indeed, if you click cancel it SHOULD close the modal

@kkatusic
Copy link
Collaborator

@LatifatAbdullahi, cc @divine-comedian, "cancel" button function fixed. Also found bug when you archived some donation it didn't remove from list, fixed also that.

@LatifatAbdullahi
Copy link

Thanks @kkatusic

Base

  • User can see network column with relevant network icon for stream balances table - Pass
  • User can see balance of streamable tokens on Base - Pass
  • User can see active,pending and ended (not archived) recurring donations on base & optimism - Pass
  • Amount donated monthly, total donated $ amounts and token amounts are corrected and update ever y ~24 hours - Pass
  • User can filter recurring donations by network, token symbol or by active/ended state - Pass
  • When filtering by token symbol it shows tokens with same symbol across multiple networks (e.g ETH on both Optimism and Base) - Pass
  • User can successfully deposit more tokens to stream balance for tokens on Base - Pass
  • User can successfully withdraw some tokens from stream balance on Base. Note: If user has stream balance with some active recurring donations using it they will not be able to withdraw 100% of their balance - Pass
  • Users can end an active recurring donation on Base - Pass
  • Users can select ended recurring donation on Base and choose action to start a new one - Pass
  • Users can select ended recurring donation on Base and archive it - Pass

Regression Test

  • Users can see balance of streamable tokens on Optimism - Pass
  • Amount donated monthly, total donated $ amounts and token amounts are corrected and update every ~24 hours for Optimism - Pass
  • Users can successfully deposit more tokens to stream balance for tokens on Optimism - Pass
  • Users can successfully withdraw some tokens from stream balance on Optimism. Note: If user has stream balance with some active recurring donations using it they will not be able to withdraw 100% of their balance - Pass
  • Users can end an active recurring donation on Optimism - Pass
  • Users can select ended recurring donation on Optimism and choose action to start a new one - Pass
  • Users can select ended recurring donation on Optimism and archive it - Pass

Issues

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Dec 30, 2024
@divine-comedian
Copy link
Contributor Author

Let's follow the issue you reported in #4875 here since it seems to be related to the checking of donations AFTER they have been made.

@kkatusic @divine-comedian

All other cases have passed, however;

All the details for the donations to projects have been updated as expected except that of recurring donation to Giveth, still showing pending and other details 0

image

@divine-comedian
Copy link
Contributor Author

divine-comedian commented Dec 30, 2024

@CarlosQ96 this seems like a back-end issue. Could you check on those recurring donations if the data is being saved correctly?

usedID: 27339
wallet: 0xd30e526d3b5a65c68c0224fdad1096c9023b4f1b

@kkatusic
Copy link
Collaborator

@divine-comedian, cc @LatifatAbdullahi, about "Archive donations" when you put that toggle button to ON state it will include archived donations inside list

@CarlosQ96
Copy link
Collaborator

@LatifatAbdullahi @divine-comedian can keep regression testing. Fixed the anchor contracts on the project Giveth, it was wrong.

@LatifatAbdullahi
Copy link

Thanks you @CarlosQ96 @kkatusic

@divine-comedian
Just retested and also completed regression test, the issue has been fixed.

image

@kkatusic
Copy link
Collaborator

Thanks you @CarlosQ96 @kkatusic

@divine-comedian Just retested and also completed regression test, the issue has been fixed.

all bravo to @CarlosQ96 !!!

@kkatusic
Copy link
Collaborator

@divine-comedian, cc @LatifatAbdullahi @CarlosQ96 , I think we fixed everything related to this issue.

@LatifatAbdullahi LatifatAbdullahi moved this from In Progress to Done in All-Devs Dec 31, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged to Production
Development

No branches or pull requests

5 participants