-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to my recurring donations page for handling base network #4884
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test Update @kkatusic @divine-comedian Base
Regression Test
Issues 1**. "Cancel" button on the "Archive" modal not working as expected**
|
Two things
|
Thanks for the clarification @divine-comedian
|
yes indeed, if you click cancel it SHOULD close the modal |
@LatifatAbdullahi, cc @divine-comedian, "cancel" button function fixed. Also found bug when you archived some donation it didn't remove from list, fixed also that. |
Thanks @kkatusic Base
Regression Test
Issues
|
Let's follow the issue you reported in #4875 here since it seems to be related to the checking of donations AFTER they have been made.
|
@CarlosQ96 this seems like a back-end issue. Could you check on those recurring donations if the data is being saved correctly? usedID: |
@divine-comedian, cc @LatifatAbdullahi, about "Archive donations" when you put that toggle button to ON state it will include archived donations inside list |
@LatifatAbdullahi @divine-comedian can keep regression testing. Fixed the anchor contracts on the project Giveth, it was wrong. |
Thanks you @CarlosQ96 @kkatusic @divine-comedian |
all bravo to @CarlosQ96 !!! |
@divine-comedian, cc @LatifatAbdullahi @CarlosQ96 , I think we fixed everything related to this issue. |
We should make some new updates to the my recurring donations page to ensures users understand recurring donations happening on different networks.
AC
Base
Regression Test
The text was updated successfully, but these errors were encountered: