Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for cbBTC recurring donations on Base #4918

Closed
8 tasks
divine-comedian opened this issue Jan 2, 2025 · 9 comments
Closed
8 tasks

add support for cbBTC recurring donations on Base #4918

divine-comedian opened this issue Jan 2, 2025 · 9 comments
Assignees

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Jan 2, 2025

We would like to support recurring donations in cbBTC, it has a high amount of volume on Base network as well.

We tried to implement it in the first release of recurring donations on Base however we were having issues with parsing and handling the unique decimals of cbBTC

we'll need to update the FE token config as well as the back-end config to handle this token @CarlosQ96

related to: #4875

Token Info

Coinbase wrapped BTC

underlying token: 0xcbB7C0000aB88B473b1f5aFd9ef808440eed33Bf
super token - cbBTCx: 0xDFd428908909CB5E24F5e79E6aD6BDE10bdf2327
details: https://explorer.superfluid.finance/base-mainnet/supertokens/0xdfd428908909cb5e24f5e79e6ad6bde10bdf2327?tab=streams

AC

  • - User can successfully create recurring donation with cbBTC
  • - User can successfully make optional donation to Giveth while making recurring donation with cbBTC
  • - user can successfully top-up balance of cbBTCx
  • - user can deposit/withdraw super token balance of cbBTC
  • - user can modify recurring donation with cbBTC
  • - user can end recurring donation with cbBTC
  • - donation table on my recurring donations and project donations page shows well formatted data
  • - donated token balances update at least every 24 hours on donation tables
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 2, 2025
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Jan 2, 2025
@Giveth Giveth deleted a comment Jan 2, 2025
@Giveth Giveth deleted a comment Jan 3, 2025
@divine-comedian divine-comedian moved this from Dev Research to Product Backlog in All-Devs Jan 7, 2025
@kkatusic kkatusic self-assigned this Jan 17, 2025
@kkatusic kkatusic moved this from Sprint Backlog to In Progress in All-Devs Jan 17, 2025
This was referenced Jan 20, 2025
@kkatusic
Copy link
Collaborator

@divine-comedian I tested all options, creating donation, deposit, withdraw, ending, also with other token seems that is running ok. When Moe provide test preview for this branch than QF can test it.

@divine-comedian divine-comedian moved this from In Progress to Code Review/PR in All-Devs Jan 21, 2025
@divine-comedian
Copy link
Contributor Author

@LatifatAbdullahi can you test this one today?

Here is the deployment link you should use for testing:

https://giveth-test-cbbtc.vercel.app/

@LatifatAbdullahi
Copy link

Yes sure

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Jan 22, 2025

Test Update

@divine-comedian @kkatusic

  • User can successfully create recurring donation with cbBTC - Pass

  • Users can successfully make optional donation to Giveth while making recurring donation with cbBTC - Pass

  • Users can successfully top-up balance of cbBTCx - Pass

  • Users can deposit/withdraw super token balance of cbBTC - Pass

  • Users can modify recurring donation with cbBTC - Pass

  • Users can end recurring donation with cbBTC _ Pass

  • Donation table on my recurring donations and project donations page shows well formatted data - Pass

  • Donated token balances update at least every 24 hours on donation tables - Pending

  • Filter the Recurring donations table by cbBTC - Pass

Issues:

  1. The Users token balance for cbBTC is not displayed on the donations page after being selected, it displays 0 instead.

Image

Image
End.Homelessness.thanks.to.Web3.Community._.Giveth.-.Google.Chrome.2025-01-22.13-02-57.mp4
  1. When Users attempt to input low values(e.g - 0.00000001 or 0.0000001), it changes to its exponential value then Users are not able to delete the value even after multiple trials, unless they highlight to delete.
Image
End.Homelessness.thanks.to.Web3.Community._.Giveth.-.Google.Chrome.2025-01-22.13-09-21.mp4
  1. When Users attempt to make a one-time donation using cbBTC, the dollar equivalent is displayed right beside the cbBTC token value inputted, after Users click on the "Donate" button, the next modal displayed does not display the cbBTC token amount and the dollar equivalent.
Image Image
  1. Users are unable to make one-time donation. Its displaying error message "Transaction failed"

Image

@divine-comedian
Copy link
Contributor Author

Thanks for the update @LatifatAbdullahi - I'll let @kkatusic investigate the issues you reported when he has time

one detail - the issue you reported regarding one-time donations we can separate out and work on in a separate issue.

@LatifatAbdullahi
Copy link

Sure.

One-time donation issue #4962

@kkatusic
Copy link
Collaborator

@LatifatAbdullahi you can check again all instead this one-donation issue, thx

@divine-comedian divine-comedian moved this from Code Review/PR to QA in All-Devs Jan 23, 2025
@LatifatAbdullahi
Copy link

@kkatusic
Issues

  • User is unable to Archive an ended cbBTC recurring donation for Project except recurring donations to Giveth community

Image

Image

@LatifatAbdullahi
Copy link

Test update

@divine-comedian @kkatusic

The issues related to the recurring donation are now fixed, the others are for one-time donation

  • User can successfully create recurring donation with cbBTC - Pass

  • Users can successfully make optional donation to Giveth while making recurring donation with cbBTC - Pass

  • Users can successfully top-up balance of cbBTCx - Pass

  • Users can deposit/withdraw super token balance of cbBTC - Pass

  • Users can modify recurring donation with cbBTC - Pass

  • Users can end recurring donation with cbBTC _ Pass

  • Donation table on my recurring donations and project donations page shows well formatted data - Pass

  • Donated token balances update at least every 24 hours on donation tables - Pass

  • Filter the Recurring donations table by cbBTC - Pass

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Jan 24, 2025
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 29, 2025
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Jan 29, 2025
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged to Production
Development

No branches or pull requests

3 participants