Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query cache is not working in some functions #1650

Closed
ae2079 opened this issue Jun 24, 2024 · 3 comments
Closed

query cache is not working in some functions #1650

ae2079 opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels

Comments

@ae2079
Copy link
Contributor

ae2079 commented Jun 24, 2024

When I was changing some code related to my issue, I realized that in some functions like this line:

const donationsUsdAmount = await query.getRawOne();
query.cache(
`donationsTotalNumberPerDateRange-${fromDate || ''}-${toDate || ''}--${
fromOptimismOnly || 'all'
}-${onlyVerified || 'all'}`,
300000,
);

query.cache() method is called after the query execution, so the cache is not set, thus the cache does not work.

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jun 26, 2024
@divine-comedian divine-comedian moved this from New Issues to Code Review/PR in All-Devs Jun 26, 2024
@ae2079
Copy link
Contributor Author

ae2079 commented Jun 27, 2024

@RamRamez
Do we need a QA test for this or we can move this issue to done state?

@RamRamez RamRamez self-assigned this Jun 28, 2024
@RamRamez
Copy link
Collaborator

@ae2079 I think it's ok to move it to done

@ae2079
Copy link
Contributor Author

ae2079 commented Jul 1, 2024

Thank you @RamRamez

@ae2079 ae2079 added Done and removed Code Review labels Jul 1, 2024
@ae2079 ae2079 closed this as completed Jul 1, 2024
@github-project-automation github-project-automation bot moved this from Code Review/PR to Done in All-Devs Jul 1, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged to Production
Development

No branches or pull requests

3 participants