Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Revoke Badge button in adminJS is handled correctly #1846

Closed
divine-comedian opened this issue Oct 1, 2024 · 4 comments
Closed

Ensure Revoke Badge button in adminJS is handled correctly #1846

divine-comedian opened this issue Oct 1, 2024 · 4 comments
Assignees
Labels
DeVerification Decentralizing Project Verification

Comments

@divine-comedian
Copy link
Collaborator

divine-comedian commented Oct 1, 2024

in the project tab when a project is selected there is a "revoke badge" button - we should make sure of two things:

  • the isGIVbacksEligible status of this project is set to false when the badge is Revoked
  • the verified status of this project is unchanged
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Oct 1, 2024
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Oct 1, 2024
@divine-comedian divine-comedian moved this from Dev Research to Product Backlog in All-Devs Oct 1, 2024
@divine-comedian divine-comedian added the DeVerification Decentralizing Project Verification label Oct 1, 2024
@RamRamez
Copy link
Collaborator

RamRamez commented Oct 3, 2024

@maryjaf @LatifatAbdullahi please test and verify this part:

  • the isGIVbacksEligible status of this project is set to false when the badge is Revoked
  • the verified status of this project is unchanged

NOTE: the revoke badge is not moved to verification form tab, it's still in project tab

@RamRamez RamRamez assigned RamRamez and unassigned MohammadPCh Oct 3, 2024
@RamRamez RamRamez moved this from Product Backlog to QA in All-Devs Oct 3, 2024
@divine-comedian divine-comedian changed the title move revoke badge to project verification form section in adminJS Ensure Revoke Badge button in adminJS is handled correctly Oct 3, 2024
@divine-comedian
Copy link
Collaborator Author

@RamRamez moved the issue for moving the button placement to a new issue -> #1854

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Oct 3, 2024

@RamRamez @divine-comedian
Admin

Givback Eligible status: True
Vouched: True

Action: Revoke Givback Eligibility

Result - Pass
Givback Eligible status: False
Vouched: True

FE
On the Admin this is confirmed working as expected, but when the the Givback Eligibility is revoked, shouldnt the FE status show "Ineligible" ?? because after I revoked the status its currently showing "Incomplete" on the FE @divine-comedian @mateodaza

@divine-comedian divine-comedian moved this from QA to Done in All-Devs Oct 3, 2024
@divine-comedian
Copy link
Collaborator Author

it depends on the status of your form - so if givbacks eligible is false it will look at the status of your application form
so this is an acceptable outcome.

@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Oct 3, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeVerification Decentralizing Project Verification
Projects
Status: Merged to Production
Development

No branches or pull requests

4 participants